From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5566E6C1AE; Wed, 19 May 2021 14:38:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5566E6C1AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621424284; bh=bWZ/M7xowjpWn8ZdQjYlo9j0CJ+zokhKpB++B/QYgYA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=V+ibjrX2Xr5mWqq3AVEQYPXHtWaw57jc/3gtsISRP3SqNKeRIvmJj1rMwJ9l0cL5V PAFHp8yonbGsO35oKDpqWAJETuRTEL1GUId7GpoJHljTBSQ+Lmz4dyXrgndMMJ37oe SkSXtO3JcTwFpgX3DlMTcr7qbU0D+AncWkw8SFk0= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 727FF6C1AE for ; Wed, 19 May 2021 14:38:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 727FF6C1AE Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1ljKWY-0007yd-7T; Wed, 19 May 2021 14:38:02 +0300 Date: Wed, 19 May 2021 14:38:00 +0300 To: Sergey Kaplun Message-ID: <20210519113800.GQ3944@tarantool.org> References: <4dd97d6fbfb470d41e9ef5ad12492a0def664b2b.1620678384.git.imun@tarantool.org> <20210512215532.GE3944@tarantool.org> <20210517172157.GO3944@tarantool.org> <20210518184728.GP3944@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210518184728.GP3944@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91B019B01C53E51AFA94C0B24B2C939D4C80F0683D6F6F7C600894C459B0CD1B92F72B557404F279AD9114030CA64184189F9AC6420C21DE2DB2FAAB0A8254537 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74B44AB1D52BB6B9BC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE75CCA5FD4E6ACD987EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D4041051E84710DC7DA53D7E7073F9965AD5CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B779389CF6F126FEC75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5EDBA19627C1D8E6B1297461D42AF1AAA985881BA83F6A252D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A503FBFE8BE8FC496EBD075491099784D5100D7C19E3B13E590C741ABA9DBCD7C7C5AB42DA8A77651D7E09C32AA3244CB1F14726BA5DCEA81901293DAF1A7461F165894D92D62706927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojF35yOkZDoIVYrH5hcT5Z/A== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822DD3D2C6CC13408A5A860D091AC639583A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] build: pass sysroot to MacOS SDK X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" As a result of offline discussion with Sergey, I've finally understood the docs and fixed the issue. Diff is below: ================================================================================ diff --git a/cmake/LuaJITUtils.cmake b/cmake/LuaJITUtils.cmake index 3497edc4..29c425de 100644 --- a/cmake/LuaJITUtils.cmake +++ b/cmake/LuaJITUtils.cmake @@ -4,7 +4,12 @@ function(LuaJITTestArch outvar strflags) # machinery) or explicitly (manually by configuration options). # Need -isysroot flag on recentish MacOS after command line # tools no longer provide headers in /usr/include. - if(CMAKE_OSX_SYSROOT) + # XXX: According to CMake documentation[1], CMAKE_OSX_SYSROOT + # variable *should* be ignored on the plaforms other than MacOS. + # It is ignored by CMake, but since this routine is extension + # it also should follow this policy. + # [1]: https://cmake.org/cmake/help/v3.1/variable/CMAKE_OSX_SYSROOT.html + if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND CMAKE_OSX_SYSROOT) set(strflags "${strflags} -isysroot ${CMAKE_OSX_SYSROOT}") endif() # XXX: simply splits the COMMAND argument by ================================================================================ On 18.05.21, Igor Munkin wrote: > Sergey, > > > > > > > diff --git a/cmake/LuaJITUtils.cmake b/cmake/LuaJITUtils.cmake > > > > > index d9f8b12a..3497edc4 100644 > > > > > --- a/cmake/LuaJITUtils.cmake > > > > > +++ b/cmake/LuaJITUtils.cmake > > > > > @@ -1,4 +1,12 @@ > > > > > function(LuaJITTestArch outvar strflags) > > > > > + # XXX: This routine uses external headers (e.g. system ones), > > > > > + # which location is specified either implicitly (within CMake > > > > > + # machinery) or explicitly (manually by configuration options). > > > > > + # Need -isysroot flag on recentish MacOS after command line > > > > > + # tools no longer provide headers in /usr/include. > > > > > + if(CMAKE_OSX_SYSROOT) > > > > > > > > Nit: This variable should be taken into account only for OS X > > > > platforms [1]. I suppose not only by CMake, but by our build system too. > > > > > > > > I've got the error on Linux if I try to build LuaJIT like the following > > > > (by mistake of course): > > > > > > > > | $ uname -s > > > > | Linux > > > > | $ cmake . -DCMAKE_OSX_SYSROOT="/tmp/blablabalblablbalalbla" -DLUA_USE_ASSERT=ON -DCMAKE_BUILD_TYPE=Debug > > > > > > Sigh. After all, I've tried for three patches, seems like ninety... > > > > > > BTW, I see failures even on MacOS: > > > | $ uname -msr > > > | Darwin 20.3.0 arm64 > > > | $ cmake . -DCMAKE_OSX_SYSROOT="/tmp" > > > | -- The C compiler identification is AppleClang 12.0.0.12000032 > > > | -- Detecting C compiler ABI info > > > | -- Detecting C compiler ABI info - failed > > > | -- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc > > > | -- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - broken > > > | CMake Error at /opt/homebrew/Cellar/cmake/3.20.1/share/cmake/Modules/CMakeTestCCompiler.cmake:66 (message): > > > | The C compiler > > > | > > > | "/Library/Developer/CommandLineTools/usr/bin/cc" > > > | > > > | is not able to compile a simple test program. > > > | > > > | It fails with the following output: > > > | > > > | Change Dir: /Users/tntmac07.tarantool.i/imun/tarantool-luajit/CMakeFiles/CMakeTmp > > > | > > > | Run Build Command(s):/usr/bin/make -f Makefile cmTC_da00c/fast && /Library/Developer/CommandLineTools/usr/bin/make -f CMakeFiles/cmTC_da00c.dir/build.make CMakeFiles/cmTC_da00c.dir/build > > > | Building C object CMakeFiles/cmTC_da00c.dir/testCCompiler.c.o > > > | /Library/Developer/CommandLineTools/usr/bin/cc -arch arm64 -isysroot /tmp -mmacosx-version-min=11.1 -MD -MT CMakeFiles/cmTC_da00c.dir/testCCompiler.c.o -MF CMakeFiles/cmTC_da00c.dir/testCCompiler.c.o.d -o CMakeFiles/cmTC_da00c.dir/testCCompiler.c.o -c /Users/tntmac07.tarantool.i/imun/tarantool-luajit/CMakeFiles/CMakeTmp/testCCompiler.c > > > | Linking C executable cmTC_da00c > > > | /opt/homebrew/Cellar/cmake/3.20.1/bin/cmake -E cmake_link_script CMakeFiles/cmTC_da00c.dir/link.txt --verbose=1 > > > | /Library/Developer/CommandLineTools/usr/bin/cc -arch arm64 -isysroot /tmp -mmacosx-version-min=11.1 -Wl,-search_paths_first -Wl,-headerpad_max_install_names CMakeFiles/cmTC_da00c.dir/testCCompiler.c.o -o cmTC_da00c > > > | ld: library not found for -lSystem > > > | clang: error: linker command failed with exit code 1 (use -v to see invocation) > > > | make[1]: *** [cmTC_da00c] Error 1 > > > | make: *** [cmTC_da00c/fast] Error 2 > > > | > > > | > > > | > > > | > > > | > > > | CMake will not be able to correctly generate this project. > > > | Call Stack (most recent call first): > > > | CMakeLists.txt:12 (project) > > > | > > > | > > > | -- Configuring incomplete, errors occurred! > > > | See also "/Users/tntmac07.tarantool.i/imun/tarantool-luajit/CMakeFiles/CMakeOutput.log". > > > | See also "/Users/tntmac07.tarantool.i/imun/tarantool-luajit/CMakeFiles/CMakeError.log". > > > > > > I have no idea how to fix this, so I propose to classify manual > > > definition of CMAKE_OSX_SYSROOT as PEBKAC and move on. Thoughts? > > > > Why we can't just change the check to the following? > > For what? The problem still exists on MacOS. Furthermore, the problem > with the same nature (from my point of view). > > > > > | if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND CMAKE_OSX_SYSROOT) > > > > At least it fixes the case I mentioned above, doesn't it? And we > > definitely can't protect users from wrong sysroot paths on OS X systems > > like in your example. This case looks like "Сам себе злобный Буратино". > > Yes, it fixes. But it does not on MacOS. Hence, why do we need to handle > this only on Linux? Moreover, who will set CMAKE_OSX_SYSROOT (not for > the testing reason) on Linux? There is even *OSX* in the variable name. > I am more concerned with the fact, one can break the build with this on > MacOS. Unfortunately, it seems in this case we can do nothing with it. > > Sorry, but I see no arguments for solving this particular case. > > Ignoring. > > > > > > > > > > | In file included from lua.h:14, > > > > | from lj_arch.h:9: > > > > | /usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/include/stdint.h:9:16: fatal error: stdint.h: No such file or directory > > > > | 9 | # include_next > > > > | | ^~~~~~~~~~ > > > > | compilation terminated. > > > > | CMake Error at cmake/LuaJITUtils.cmake:48 (message): > > > > | [LuaJITArch] Unsupported target architecture > > > > | Call Stack (most recent call first): > > > > | cmake/SetTargetFlags.cmake:16 (LuaJITArch) > > > > | src/CMakeLists.txt:17 (include) > > > > > > > > > + set(strflags "${strflags} -isysroot ${CMAKE_OSX_SYSROOT}") > > > > > + endif() > > > > > # XXX: simply splits the COMMAND argument by > > > > > # spaces with no further parsing. At the same time GCC is bad in > > > > > # argument handling, so let's help it a bit. > > > > > > > > > > ================================================================================ > > > > > > > > > > [1]: https://gitlab.kitware.com/cmake/cmake/-/blob/master/Source/cmLocalGenerator.cxx#L1911-1916 > > > > > [2]: https://gitlab.kitware.com/cmake/cmake/-/blob/master/Tests/FindPackageModeMakefileTest/CMakeLists.txt#L24-28 > > > > > > > > > > > > > > > -- > > > > > Best regards, > > > > > IM > > > > > > > > [1]: https://cmake.org/cmake/help/v3.0/variable/CMAKE_OSX_SYSROOT.html > > > > > > > > -- > > > > Best regards, > > > > Sergey Kaplun > > > > > > -- > > > Best regards, > > > IM > > > > -- > > Best regards, > > Sergey Kaplun > > [1]: https://github.com/LuaJIT/LuaJIT/commit/8961a92 > > -- > Best regards, > IM -- Best regards, IM