From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 27E466EC5B; Fri, 14 May 2021 13:52:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 27E466EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620989549; bh=i0IHIrBn0et0UP9tsS+4kHaFcMzg4zY3R5dljEe5XZc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lKMmA93QPhmc6XlhPG5PJILa6eUHUaX9R8otnx+5Z4Qddwjls4zZqjJCxnFNgWdaq /Sd3JMiQdnFXIUsZ1+vivfuQ5UUL3E1ZYkWfIYgN7mumBw1yWwkvvskU0a06DnZMOO 1lOROp4J/tqhFJOf9IC3Q/XfjWrdWH0o1OvG0xjg= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 502B96EC5B for ; Fri, 14 May 2021 13:52:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 502B96EC5B Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lhVQh-00039S-Cc; Fri, 14 May 2021 13:52:27 +0300 Date: Fri, 14 May 2021 13:31:13 +0300 To: Sergey Ostanevich Message-ID: <20210514103113.GH3944@tarantool.org> References: <6753245c0309ed77250a6ac41fb7bfd3f82676c2.1620678384.git.imun@tarantool.org> <20210511113115.GD3944@tarantool.org> <2922F816-67DD-45D0-8F97-6CA2EB36F66E@tarantool.org> <20210512215956.GF3944@tarantool.org> <20210513104418.GG3944@tarantool.org> <3023B2B8-259B-466D-8218-818D01B0D721@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3023B2B8-259B-466D-8218-818D01B0D721@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0BB6090B4F8997C21AA3492AFA30115D5182A05F538085040C2F8A547C18D189065649F91B8E88230E5F14032D5DD7994A6CEB15F17800B04 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74AA616721CED6291EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637802D3462438662818638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87ABB15DD86CC54437245423315F74F8B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6821DB69C87B6DA73089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A58EEAC589643C8C2A50DA489CC9AE4AE31EF3A70AF1C8280BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75438CC92D4039F4E2410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C1D376EF32BB089685581EC852ECCB8728F62A221B17B4356EC161819E23574BEACAB4F9C5326DAF1D7E09C32AA3244C49ACE85648AC617807856A00548C4710A8CE788DE6831205927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoybArHp+PQVS4tOZt440uA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638221A70CCE9A221D9923727CEAB948CB302A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergos, On 14.05.21, Sergey Ostanevich wrote: > > > Anyway, I see this is unclear to you, but everything is OK for Sergey. > > Do I need to reword this part of commit message or even drop it? > > Just update the wording Copy. > > All LJ_TARGET_IOS uses in FFI sources are done with LJ_TARGET_ARM64 define being > set, so we can simply replace these occurrences with LJ_TARGET_OSX. Here is the final wording: | FFI/ARM64/OSX: Fix vararg call handling. | | Thanks to Igor Munkin. | | (cherry picked from commit 521b367567dc5d91d7f9ae29c257998953e24e53) | | This patch fixes the issue introduced by commit | 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203 ('OSX/iOS: Handle iOS simulator | and ARM64 Macs.'). Within the mentioned commit LJ_TARGET_IOS define is | set via Apple system header to enable several features (e.g. JIT and | external unwinder) on ARM64 Macs, but its usage was not adjusted | source-wide. This is done for FFI machinery within this commit. | | All LJ_TARGET_IOS uses in FFI sources are done with LJ_TARGET_ARM64 | define being set, so we can simply replace these occurrences with | LJ_TARGET_OSX. | | Igor Munkin: | * added the description and the test for the problem | | Resolves tarantool/tarantool#6066 | Part of tarantool/tarantool#5629 | Relates to tarantool/tarantool#5983 | | Reported-by: Nikita Pettik | Reviewed-by: Sergey Kaplun | Reviewed-by: Sergey Ostanevich | Signed-off-by: Igor Munkin > > And it’s LGTM. Also added your tag, thanks! > > Sergos > -- Best regards, IM