From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4073D6EC5B; Fri, 14 May 2021 10:57:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4073D6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620979020; bh=fbuMcWBzl9CQuy4eL51TeNdcdP/IX8mcY1wOeyqM9H0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=k+PJy6/FeqKNPd3tw1vlJCW9wxEIKXtbuo2Aq+3KSXBlA3kRAE6hMERLa+v8ljPQn DT6n/ffbMKxMUZ3/12pBv7GJV9/GZXHGvW4+S1iwgmOKxV20ZRQ0RuVQFR6tdFjwTi uswKPsj4YfKSHhvCx4xvQDH4i/TdAwZhLTts1lkU= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 86D046EC5B for ; Fri, 14 May 2021 10:56:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 86D046EC5B Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1lhSgs-0000SM-LA; Fri, 14 May 2021 10:56:59 +0300 Date: Fri, 14 May 2021 07:56:58 +0000 To: Cyrill Gorcunov Message-ID: <20210514075658.p55khpwqfhhzj7eb@tarantool.org> References: <20210504155819.290874-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210504155819.290874-1-gorcunov@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE022900C3053DBED76BEB47C8A8E1FDA50182A05F538085040DCB816B87B5B0089FE2B5521B02C56CAE8096DEF9C1F8EBC68A51C136D57CDD9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637629A2DB6D7098C1B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81647F9831EF8E5316195127281F72834117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3733B5EC72352B9FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520140C956E756FBB7AC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE1E561CDFBCA1751F9D765CF6BB0EE041D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE30CABCCA60F52D7EB302FCEF25BFAB345C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377870F476E0DB9443EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5405CF5F88B58AA4ED1A2E96AC7FCDB4C2E860BCD0A9CD021D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75438CC92D4039F4E2410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D1F112031EF3D62A08B2084F31B6EFF9D4F8BFE289BA8105ED1505321D19AC2D741327856D161DA1D7E09C32AA3244C60EDF79391173B184C907312F29E77F7A90944CA99CF22E3927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoybArHp+PQVb2mRlqbyw8g== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD2E6EB1A89C7BC48AEC559EB3278B0956CCB345D7DBB60B20BCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Cc: tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 04 май 18:58, Cyrill Gorcunov wrote: > We've been notified that if tarantool instance is running for > long time slice the logger start to print weird lines such as > > | main/-244760339/cartridge.failover.task I> Instance state changed > > where fiber's ID represented as a negative number. Eventually we > discovered a few issues > > - a bunch of say_x called with wrong specificators but compiler > simply ignored it > - fiber IDs are wrapping and this is inconvenient > - CFORMAT simply doesn't work > > In the series we fix all these issues. Note that using simplified > form for unsigned arguments such as > > "%llu", (long long)(uint64_t) > > is pretty fine becase signed/unsiged values are counterpart of > each other guaranteed by standart. > > issue https://github.com/tarantool/tarantool/issues/5846 > branch gorcunov/gh-5846-fid-name-3 I've checked your patch set into master. -- Regards, Kirill Yukhin