From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A2F836EC5B; Thu, 13 May 2021 14:05:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A2F836EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620903934; bh=8b6Vx+jSOV0CUzZlQqPvmmVvATc7WTNek3HOr+ZdSeY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wjFgsZ0tJuMUDhFtY5GpLiErFBHKGH9t9SiUEK34BKc3TKSdePC3thaPWNSS+uKT8 87S8kntLF1NtMvKzSK2bapDOiQe6y1vyTlIW/7i5G9Pz10m9MbTb2o9sW2S1w/uv7n rQJxWB9Iui/o8fj5UaIZxFH5viG9O6+XOn4Q4ke0= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7A1036EC5B for ; Thu, 13 May 2021 14:05:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7A1036EC5B Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lh99o-0006UB-8v; Thu, 13 May 2021 14:05:32 +0300 Date: Thu, 13 May 2021 13:44:18 +0300 To: Sergey Ostanevich Message-ID: <20210513104418.GG3944@tarantool.org> References: <6753245c0309ed77250a6ac41fb7bfd3f82676c2.1620678384.git.imun@tarantool.org> <20210511113115.GD3944@tarantool.org> <2922F816-67DD-45D0-8F97-6CA2EB36F66E@tarantool.org> <20210512215956.GF3944@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0B2C7F7C3B0039F139F0EF8E3717E163C182A05F53808504052A263D29733E32F7A2407B5C4FFA709233C98C727EBBDDFD92CFDF5CBF4E31B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70FFC2100EB7B6895EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374E88016F1B7D8D248638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B27A504FAA921FF5CB40109A920A8E11028CCF7685675CC1A7D2E47CDBA5A96583C09775C1D3CA48CFCF36E64A7E3F8E58117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7850F8B975A76562C9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5C262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A532BB1B9E4FC31E2F50F942665A5CF9EB0A4600AA9809E95DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F05B761BB9C2AA441A5B2E5D5140DF00F05ABC21ADAADD97052B27ED91A838A1FFF56D9FCAE09B371D7E09C32AA3244CA7B4723DC168484A967D4CEE80FE41ED60759606DA2E136A927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoybArHp+PQXdhe94w7Y2vA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638229F9490D8FD0264B4F395DB8533DE1281A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergos, On 13.05.21, Sergey Ostanevich wrote: > Well, this doesn't help me with > > > Since all LJ_TARGET_IOS usage is done with LJ_TARGET_ARM64 define being > > set, we can simply replace all occurrences with LJ_TARGET_OSX. OK, as a result of offline discussion I've finally got it (hope you too). Everything written above relates only to FFI sources that are touched within this changeset (consider FFI prefix in commit subject). > > alongside with > > > src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS Strictly saying, this commit[1] has not been backported yet. > > because if we apply first then the second will evaluate into > > src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_OSX > > which is always false? > > Also there are still operable 32bit apps, including games, so iOS > still supports 32bits - can this change cause problems? I believe Mike > doesn’t care too much, so it can easily slip through. As we discussed, 32-bit platforms are not touched in this commit, so nothing criminal. Anyway, I see this is unclear to you, but everything is OK for Sergey. Do I need to reword this part of commit message or even drop it? > > Sergos > > > > > On 13 May 2021, at 00:59, Igor Munkin wrote: > > > > Sergos, > > > > On 12.05.21, Sergey Ostanevich wrote: > >> Hi! > >> > >> I can’t get this then > >> > >> src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS > > > > There is a verbose comment nearby[1] and the corresponding issue[2]. > > > >> > >> How’s that survived in 2.1 branch? > >> > >> regards, > >> Sergos > >> > >> > >>> On 11 May 2021, at 14:31, Igor Munkin wrote: > >>> > >>> Sergey, > >>> > >>> Thanks for your review! > >>> > >>> On 11.05.21, Sergey Kaplun wrote: > >>>> Hi, Igor! > >>>> > >>>> Thanks for the patch! > >>>> LGTM! > >>> > >>> Added your tag: > >>> | Reviewed-by: Sergey Kaplun > >>> > >>> Also mentioned the issue[1]: > >>> | Resolves tarantool/tarantool#6066 > >>> > >>>> > >>>> -- > >>>> Best regards, > >>>> Sergey Kaplun > >>> > >>> [1]: https://github.com/tarantool/tarantool/issues/6066 > >>> > >>> -- > >>> Best regards, > >>> IM > >> > > > > [1]: https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L119 > > [2]: https://github.com/LuaJIT/LuaJIT/issues/668 > > > > -- > > Best regards, > > IM > [1]: https://github.com/LuaJIT/LuaJIT/commit/7877369 -- Best regards, IM