From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9FB326EC5B; Thu, 13 May 2021 01:21:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9FB326EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620858072; bh=rvyKPqjAwJ+4LQOzJAbIPeTvYTbHsHeZ5s8R9WUYucc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=W2mREiVhz7k9BuV7Kwv1BjyZE364JyDRa7nugP9OLaidZZW0DMrRZrwFpRBfIs4vn X5ryuKpOYwZdqKowTf97srQv1/dP4NGEkGtbd0Gz2EVuG50hTs8Cs9h2KuyU6MKPh5 DBVPulxXDD97CM1+6F0VDBUNZJ+FMBODv+WtDp8I= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ECCB56EC5B for ; Thu, 13 May 2021 01:21:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ECCB56EC5B Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lgxE6-0002UR-3f; Thu, 13 May 2021 01:21:10 +0300 Date: Thu, 13 May 2021 00:59:56 +0300 To: Sergey Ostanevich Message-ID: <20210512215956.GF3944@tarantool.org> References: <6753245c0309ed77250a6ac41fb7bfd3f82676c2.1620678384.git.imun@tarantool.org> <20210511113115.GD3944@tarantool.org> <2922F816-67DD-45D0-8F97-6CA2EB36F66E@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2922F816-67DD-45D0-8F97-6CA2EB36F66E@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE022900C3053DBED76BEB47C8A8E1FDA50182A05F53808504079BC62F20A16C3DA913AB50C65DCB4B95A7CFA51C1C4A4ED099DD17C39C9E69F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74FC7AD0AD96C1577EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FF37B1FF54E2C7C48638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2653FF57034D53AB106510AD7A9CC71BE11D9A310A4A5EBA7D2E47CDBA5A96583C09775C1D3CA48CFED8438A78DFE0A9E117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5C156CCFE7AF13BCA4B5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831E1B70A3B1000301C3AC67FABDE5538EC X-C1DE0DAB: 0D63561A33F958A5B4C88002BCB68EFC9FA814E5CC83DC28C3FBB0ED4E8953D3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342F9EE325F82A28A8597967463A87CCAC5F2652B6CF1FBFAC9F7FB532CCBDC37B8D10C9A9381AF8431D7E09C32AA3244C5A207EDB5371842411D74F4F937D10381DD47778AE04E04D927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojo6y/qPNd2uwLRPvdWHSaXQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382256017BF37533A1B6E40694D2FDD8D4A6A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergos, On 12.05.21, Sergey Ostanevich wrote: > Hi! > > I can’t get this then > > src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS There is a verbose comment nearby[1] and the corresponding issue[2]. > > How’s that survived in 2.1 branch? > > regards, > Sergos > > > > On 11 May 2021, at 14:31, Igor Munkin wrote: > > > > Sergey, > > > > Thanks for your review! > > > > On 11.05.21, Sergey Kaplun wrote: > >> Hi, Igor! > >> > >> Thanks for the patch! > >> LGTM! > > > > Added your tag: > > | Reviewed-by: Sergey Kaplun > > > > Also mentioned the issue[1]: > > | Resolves tarantool/tarantool#6066 > > > >> > >> -- > >> Best regards, > >> Sergey Kaplun > > > > [1]: https://github.com/tarantool/tarantool/issues/6066 > > > > -- > > Best regards, > > IM > [1]: https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L119 [2]: https://github.com/LuaJIT/LuaJIT/issues/668 -- Best regards, IM