From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6204C6F3C4; Tue, 11 May 2021 14:24:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6204C6F3C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620732261; bh=zHIBxEpoJcl1ilVnzGO70pu8Q93vFq72ssv1pKmY4FA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Jiyx8sCUYI6eL0M9CZzb/2B3zkKhPGg62Gcqidry/XqZL+a3vkY4LH0FmxCjBm6Tz imjbDP2RfkaKNCjKxOskTmaHPTe6jjtBJgjFm1Z0/SBYQ9JV/oGiI2qge+79bN8+mg DA36MSk6FKwmWq18nrhN23W/QmIhiaYjD9N8RpMA= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 243246F3C4 for ; Tue, 11 May 2021 14:24:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 243246F3C4 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lgQUs-0005Pi-Qz; Tue, 11 May 2021 14:24:19 +0300 Date: Tue, 11 May 2021 14:03:05 +0300 To: Sergey Kaplun Message-ID: <20210511110305.GC3944@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0B2C7F7C3B0039F1303CE517DE434612D182A05F538085040B6BAF292DBEF5943AA403BD7FC6E6A1C997224946B83823CA61D9AE25F401EC1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE727FD6E7FC3A8F857EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374A24022C550661178638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2B4626E62B0516797D0FB427BF3B119E551ACFDFAE348AC99D2E47CDBA5A96583C09775C1D3CA48CF7EF884183F8E4D67117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE764603B5C71CE8B8F9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5CA91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A55B5535C98E7EB1D22846D652C78C696482C848AACDE38417D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AF61ACC197BF517A6361B0B4E98076439890E0ABE26E4BD7923578778BC3BC097001C8B8C0933A3C1D7E09C32AA3244C937C5276507B5C5E0B588F29C8689FBB8580396430872480927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPN2Bz4bQWZs7zMPe0oZmrg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822799CBAB9AAB45E1DEA291C364284F616A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] OSX/iOS: Handle iOS simulator and ARM64 Macs. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! I've made some minor changes to associate this patch with the proper issue[1]. Diff is below: ================================================================================ diff --git a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua similarity index 82% rename from test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua rename to test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua index b23dd712..7110e351 100644 --- a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua +++ b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua @@ -1,6 +1,6 @@ local tap = require('tap') -local test = tap.test('gh-5983-jit-library-smoke-tests') +local test = tap.test('gh-6065-jit-library-smoke-tests') test:plan(1) -- Just check whether LuaJIT is built with JIT support. Otherwise, ================================================================================ On 11.05.21, Sergey Kaplun wrote: > > Hi, Igor! > > Thanks for the patch! LGTM! Added your tag: | Reviewed-by: Sergey Kaplun > > On 11.05.21, Igor Munkin wrote: > > From: Mike Pall > > Side note: I am a little bit confused by this line (I thought that it is > a part of the commit message). May be it is better to drop it or to > write like: Hm, this looks like a common practice if *you* send *someone's* patch to be applied. IIRC, git am takes the entry below as commit author. > > | # From: Mike Pall > > > > > (cherry picked from commit 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203) > > > > After Apple released Macs working on ARM64, the previous recipe in > > lj_arch.h for detecting various Apple platforms is not valid anymore. > > Fortunately, there is a system header (i.e. TargetConditionals.h), > > provided by SDK with the proper defines to be set. Starting from this > > patch, LuaJIT identifies Apple hosts via this header. > > > > Since testing machinery assumes that LuaJIT is built with JIT support > > being enabled unconditionally, a smoke test for it is also added > > alongside with this patch. > > > > Igor Munkin: > > * added the description and the test for the problem > > * backported the original patch to tarantool/luajit repo > > Mentioned the issue[1]: | Resolves tarantool/tarantool#6065 > > Part of tarantool/tarantool#5629 > > Relates to tarantool/tarantool#5983 > > > > Signed-off-by: Igor Munkin > > --- > > > > > -- > Best regards, > Sergey Kaplun [1]: https://github.com/tarantool/tarantool/issues/6065 -- Best regards, IM