From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tml <tarantool-patches@dev.tarantool.org> Cc: Alexander Turenko <alexander.turenko@tarantool.org> Subject: [Tarantool-patches] [PATCH] lua/log: accept symbolic logging levels Date: Fri, 7 May 2021 14:13:05 +0300 [thread overview] Message-ID: <20210507111305.564935-1-gorcunov@gmail.com> (raw) Currently `log` module accepts only numeric values of logging levels. I turn `box.cfg` interface supports symbolic names (such as 'fatat', 'crit' and etc). Thus we should support the same in `log` module. Closes #5882 Reported-by: Alexander Turenko <alexander.turenko@tarantool.org> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- issue https://github.com/tarantool/tarantool/issues/5882 branch gorcunov/gh-5882-logger-strings changelogs/unreleased/gh-5882-log-levels.md | 13 +++++++++++++ src/lua/log.lua | 6 ++++++ 2 files changed, 19 insertions(+) create mode 100644 changelogs/unreleased/gh-5882-log-levels.md diff --git a/changelogs/unreleased/gh-5882-log-levels.md b/changelogs/unreleased/gh-5882-log-levels.md new file mode 100644 index 000000000..08f9595be --- /dev/null +++ b/changelogs/unreleased/gh-5882-log-levels.md @@ -0,0 +1,13 @@ +## feature/lua/log + + * Implemented support of symbolic log levels representation + in `log` module (gh-5882). Now it is possible to specify + levels the same way as in `box.cfg{}` call. For example + instead of + ``` Lua + require('log').cfg{level = 6} + ``` + One can use + ``` Lua + require('log').cfg{level = 'verbose'} + ``` diff --git a/src/lua/log.lua b/src/lua/log.lua index 62ea61f2d..788560722 100644 --- a/src/lua/log.lua +++ b/src/lua/log.lua @@ -499,6 +499,12 @@ local function load_cfg(self, cfg) local m = "log.cfg: \'%s\' %s" error(m:format('level', msg)) end + -- Convert level to a numeric value since + -- low level api operates with numbers only. + if type(cfg.level) == 'string' then + assert(log_level_keys[cfg.level] ~= nil) + cfg.level = log_level_keys[cfg.level] + end end if cfg.nonblock ~= nil then -- 2.30.2
next reply other threads:[~2021-05-07 11:13 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-07 11:13 Cyrill Gorcunov via Tarantool-patches [this message] 2021-05-07 11:17 ` Cyrill Gorcunov via Tarantool-patches 2021-05-26 11:04 ` Serge Petrenko via Tarantool-patches 2021-05-26 22:04 ` Alexander Turenko via Tarantool-patches 2021-05-27 7:53 ` Cyrill Gorcunov via Tarantool-patches 2021-05-27 9:04 ` Alexander Turenko via Tarantool-patches 2021-05-27 10:17 ` Cyrill Gorcunov via Tarantool-patches 2021-06-01 12:25 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210507111305.564935-1-gorcunov@gmail.com \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=gorcunov@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH] lua/log: accept symbolic logging levels' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox