From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tml <tarantool-patches@dev.tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers Date: Tue, 4 May 2021 18:58:09 +0300 [thread overview] Message-ID: <20210504155819.290874-1-gorcunov@gmail.com> (raw) We've been notified that if tarantool instance is running for long time slice the logger start to print weird lines such as | main/-244760339/cartridge.failover.task I> Instance state changed where fiber's ID represented as a negative number. Eventually we discovered a few issues - a bunch of say_x called with wrong specificators but compiler simply ignored it - fiber IDs are wrapping and this is inconvenient - CFORMAT simply doesn't work In the series we fix all these issues. Note that using simplified form for unsigned arguments such as "%llu", (long long)(uint64_t) is pretty fine becase signed/unsiged values are counterpart of each other guaranteed by standart. issue https://github.com/tarantool/tarantool/issues/5846 branch gorcunov/gh-5846-fid-name-3 Cyrill Gorcunov (10): fiber: use uint64_t for fiber IDs popen: fix say_x format arguments raft: fix say_x arguments box/error: fix argument for CustomError xlog: fix say_x format box/vynil: fix say_x format txn: fix say_x format limbo: fix say_x format wal: fix say_x format say: fix CFORMAT specification changelogs/unreleased/gh-5846-cformat.md | 12 +++++++++ changelogs/unreleased/gh-5846-fiber-id.md | 4 +++ src/box/error.cc | 2 +- src/box/txn.c | 3 ++- src/box/txn_limbo.c | 2 +- src/box/vy_scheduler.c | 2 +- src/box/wal.c | 17 ++++++------ src/box/xlog.c | 4 +-- src/lib/core/fiber.c | 30 ++++++++++----------- src/lib/core/fiber.h | 8 +++--- src/lib/core/popen.c | 4 +-- src/lib/core/say.c | 8 +++--- src/lib/core/say.h | 2 +- src/lib/raft/raft.c | 5 ++-- src/lua/fiber.c | 33 ++++++++++++----------- 15 files changed, 79 insertions(+), 57 deletions(-) create mode 100644 changelogs/unreleased/gh-5846-cformat.md create mode 100644 changelogs/unreleased/gh-5846-fiber-id.md base-commit: 4500547d7a177c0b49bff35c922286b4f21c8719 -- 2.30.2
next reply other threads:[~2021-05-04 16:03 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-04 15:58 Cyrill Gorcunov via Tarantool-patches [this message] 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 01/10] fiber: use uint64_t for fiber IDs Cyrill Gorcunov via Tarantool-patches 2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-10 21:40 ` Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 02/10] popen: fix say_x format arguments Cyrill Gorcunov via Tarantool-patches 2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-10 21:41 ` Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 03/10] raft: fix say_x arguments Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 04/10] box/error: fix argument for CustomError Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 05/10] xlog: fix say_x format Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 06/10] box/vynil: " Cyrill Gorcunov via Tarantool-patches 2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-10 21:51 ` Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 07/10] txn: " Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 08/10] limbo: " Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 09/10] wal: " Cyrill Gorcunov via Tarantool-patches 2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-10 21:55 ` Cyrill Gorcunov via Tarantool-patches 2021-05-04 15:58 ` [Tarantool-patches] [PATCH v3 10/10] say: fix CFORMAT specification Cyrill Gorcunov via Tarantool-patches 2021-05-10 18:40 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-10 21:58 ` Cyrill Gorcunov via Tarantool-patches 2021-05-11 20:13 ` [Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers Vladislav Shpilevoy via Tarantool-patches 2021-05-11 21:15 ` Cyrill Gorcunov via Tarantool-patches 2021-05-11 21:24 ` Cyrill Gorcunov via Tarantool-patches 2021-05-12 18:41 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-13 8:17 ` Cyrill Gorcunov via Tarantool-patches 2021-05-13 11:17 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-13 11:44 ` Cyrill Gorcunov via Tarantool-patches 2021-05-13 12:09 ` Vladislav Shpilevoy via Tarantool-patches 2021-05-14 7:56 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210504155819.290874-1-gorcunov@gmail.com \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox