From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A56C86F87A; Wed, 28 Apr 2021 16:38:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A56C86F87A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619617102; bh=swU+M8w/TXzh+2Gm/hl8fhTA8f7BcQVvQZWCujlQ5N4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=J4ou6mCGUOiYhLaxs1QjB69mVGXYDeZvXElHYvXLXQMUu3hU2AZP55s+DSnr8vrY+ nAl1d2whl/ny8L0sWAHEOsxDAc3OHndus4GhS23jxnSqvj2C15pEOKl7XFk+jsjyRY 2gA4FDeRHuOqki4pwXadMhaJJJr2cDdqy8qhjsIA= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0C33F6F87A for ; Wed, 28 Apr 2021 16:38:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0C33F6F87A Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lbkOR-0006DN-5D; Wed, 28 Apr 2021 16:38:19 +0300 Date: Wed, 28 Apr 2021 16:17:08 +0300 To: Nikita Pettik Message-ID: <20210428131708.GB24014@tarantool.org> References: <5465d7bc81f04842dcdb65f222db381036c0659c.1619561872.git.imun@tarantool.org> <20210428112849.GA30576@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210428112849.GA30576@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ECFD8CE5F0594010C798B26A9CF6FD3F2B2BC7AAFDCADAFC182A05F538085040073F6A14C468FBB10C38E7E1CF56FBF382606347A05B76C7C7CA3C74155CDA7C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7495A032B936E882FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F757A79C3007ACA28638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2B880932BBCD17C59509B058348957AEB07164437C8F97EC6D2E47CDBA5A96583C09775C1D3CA48CF7EF884183F8E4D67117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5C57739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: 2623F767319EFA42AC98609FCEE262F9192335DD689A58EBAE0174B7F1092AFB5E9D0A81291C92A002B383485BD0C5C9 X-C1DE0DAB: 0D63561A33F958A53C3B8D0903C469129684BEA69075B391A29A39D7CD174FC3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3483E1FCD56FEA62E604903D3F510A298C46A9599998416D107375E5DC8DC062836CA9E9C818D38E551D7E09C32AA3244C442E9A649C08E840EBE20C1DE148F99A725D5B54B2FE45758D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoCaqxM2e5sqRojjiB5QWqA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822DCA6AFCC6FD1F9A7C615BA25F050BC0BA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: fix linker flags for executable on MacOS X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Nikita, Thanks for your review! On 28.04.21, Nikita Pettik wrote: > On 28 Apr 01:46, Igor Munkin wrote: > > This patch fixes inaccuracy in Tarantool build configuration introduced > > by commit 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust > > LuaJIT build system'). All those MacOS-related tweaks for __PAGEZERO > > size and preferred load address for the bundle are necessary only for > > builds with 32-bit GC area on 64-bit host. The only case fitting these > > conditions is x86_64 with no LUAJIT_ENABLE_GC64. All other 64-bit builds > > use 64-bit GC area unconditionally. > > > > Part of #5983 > > Needed for #5629 > > Follows up #4862 > > > > Signed-off-by: Igor Munkin > > --- > > LGTM Added your tag: | Reviewed-by: Nikita Pettik > -- Best regards, IM