From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B3A6E6F87A; Wed, 28 Apr 2021 13:22:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B3A6E6F87A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619605378; bh=qW+nz9ytXvjLgM69cKAIMpm9B21aihzDyIan3yK58+A=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=xoPGiTslhH7r1hSHSTDm5KwKWVwLaSoJpbhUFATGRrZGAgzttvlsCCUNrceGKc1rj eslOtudrNIQUkrkuyr6cxIq3ukLOPVJgKnjFQj1VrHCPpikZjuJ/a8JZD5cCkSM0Um RHgDZgSnWG3k5L8DaNdFFVCQs8vWoO8FRLCorCME= Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BB7FF6F87A for ; Wed, 28 Apr 2021 13:22:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BB7FF6F87A Received: by mail-lj1-f177.google.com with SMTP id o16so71642039ljp.3 for ; Wed, 28 Apr 2021 03:22:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sHJc5ElPFr//hmscy7TdvRWRUhkffYVz9xTyTrQ+O+c=; b=jbMwUEm4WSysVJmx3DeCOaXohTKcmxraALG5JntP2FVEw+ja6WP5bP7VaaxBVkbdwx KtIunWEX1VBoR6rDjefq/XT5muYmSHLcBKHC7qnHOe/sTsrpyEABlH1KBAIoKyoSiTdo lPw1ElLMIIdm1Rd9W//nmy6y5DyRt4hJ+UqVHzCAmuAt1HO37xFloPju3F6MKcPod/Zz tDPYPcxL9Kxd7RQHUQ2TYRT0DKxgi+IGTrZEJjHoJpTpAGk2ZOac6mC8PTuyRTlVKAWo fZ8WCk2rEx5RLtwPSWL862SiNpnF7GmAZbwZ8eYVXCyYWqYOz4eNP/0yr4vGKuisI6AM WdBw== X-Gm-Message-State: AOAM532KB26CEpXfX0TWEL9uFJue672eZtX02oD8lrcLRdM8H+PsVHNU lSjod6q2shh/OPHvSMYprBGxuYNyFU4= X-Google-Smtp-Source: ABdhPJzlQ5CvcjpKIjrtoS0I4zXngmYmqdxwG1cFy8Tr9nLO1v2ad7CnoVaO3uc7/TfJHGYTpWvprQ== X-Received: by 2002:a2e:b04d:: with SMTP id d13mr20336750ljl.448.1619605376789; Wed, 28 Apr 2021 03:22:56 -0700 (PDT) Received: from grain.localdomain ([5.18.199.94]) by smtp.gmail.com with ESMTPSA id k5sm1081677ljg.33.2021.04.28.03.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 03:22:55 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 0602A560107; Wed, 28 Apr 2021 13:22:54 +0300 (MSK) To: tml Date: Wed, 28 Apr 2021 13:22:49 +0300 Message-Id: <20210428102251.552976-1-gorcunov@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v2 0/2] fiber: prevent fiber_join from misuse X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" v2 (by Vlad): - Use explicit != 0 form for flag testing - in Lua's fiber:join() drop the test for FIBER_IS_JOINABLE flag since now we do the same on lower level - extend tests - provide changelog issue https://github.com/tarantool/tarantool/issues/6046 branch gorcunov/gh-6046-fiber-join-2 Cyrill Gorcunov (2): fiber: fiber_join -- drop redundat variable fiber: fiber_join -- don't crash on misuse .../unreleased/gh-6046-fiber-join-misuse.md | 6 ++++ src/lib/core/fiber.c | 12 +++++-- src/lua/fiber.c | 10 ++++-- test/app/fiber.result | 34 +++++++++++++++++++ test/app/fiber.test.lua | 12 +++++++ test/unit/fiber.cc | 7 ++++ 6 files changed, 75 insertions(+), 6 deletions(-) create mode 100644 changelogs/unreleased/gh-6046-fiber-join-misuse.md base-commit: f44663ed75769a20095ff09f728e9b29f9319dc5 -- 2.30.2