From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 913FB6EC5F; Tue, 20 Apr 2021 00:06:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 913FB6EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618866377; bh=pzY/bRkw4/vuykhscFcSQq4ItulFw5xdaDhdIH5xmUs=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AiJzCa4sWrOzrufE/MBMqMIPReNLNzpd/hoG9F6wxrLlVG+xZ+CwUOGrOAeMwC6pN QxsvMuX6/5ZBvj/p/9Un4YJGiyvrxrWilUTxRU2or00l2xm19vNQYh0zHJGlnaxu5g UdxfrJJX2hjUEhNHhxGPBVIKmOUGYGmmrbhvJiOo= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3BDA66EC5F for ; Tue, 20 Apr 2021 00:06:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3BDA66EC5F Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lYb5z-0006cp-84; Tue, 20 Apr 2021 00:06:15 +0300 Date: Tue, 20 Apr 2021 00:06:02 +0300 To: Sergey Bronnikov Cc: Alexander Turenko , tarantool-patches@dev.tarantool.org Message-ID: <20210419210602.GF29703@tarantool.org> References: <7f444b92bacefea0e3a0b2d2846737d9791626ea.1614256802.git.imun@tarantool.org> <0a7f111d-7119-bd2d-020d-1938edeb973e@tarantool.org> <20210311121342.GV9042@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480B1C8842CE613979723F2FB4628545A35182A05F538085040D1A5E2A3C16B1E87D8505533EFD483CBDE0C2C52EFB9A3B207CE5276CEC7266C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74B7EDB5828CF9C27EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373880C950E4B364568638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2409A0149002474069D32B5124BA998BD7D6ED8DD83F142CB02ED4CEA229C1FA827C277FBC8AE2E8B92E378BE266A6926A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978311834A9DC20D8F35299F3B6BFDA6AA5C4 X-C1DE0DAB: 0D63561A33F958A582C535144499C00CEFA149152F33D465B4BC94F763535851D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC223B6CC5B2DFAC5ADF27F535D1A04D2304F0E24A558B93A7BDE557D3C219BF6175838A28CF7BA01D7E09C32AA3244CE289C790182BEBC1AF603AE434A6013C7101BF96129E4011927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojocJA+pXcDulrwKJn+Hh3hA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638225D673F60C0626EFD48DA7E29700CF022A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] tools: implement toolchain for crash artefacts X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 24.03.21, Sergey Bronnikov wrote: > Igor, > > thanks for changes! Generally LGTM with two notes inline. Added your tag: | Reviewed-by: Sergey Bronnikov > > On 11.03.2021 15:13, Igor Munkin wrote: > > Sergey, > > > > Thanks for your review! > > > > On 03.03.21, Sergey Bronnikov wrote: > > >> 2. I propose to show files included to the report and the end of creation. > > Well, I believe I didn't understand you right before (this list is > > included to the archive). Anyway, now I added the list also to the > > message at the end. > > You got it right. > > > > > 1. in a private conversation we decided to remove mention of public > resource in a message "http://transfer.sh". Removed. Diff is below: ================================================================================ diff --git a/tools/tarabrt.sh b/tools/tarabrt.sh index e09d051a4..b484fc9fb 100755 --- a/tools/tarabrt.sh +++ b/tools/tarabrt.sh @@ -289,7 +289,7 @@ The archive contents are listed below: $(cat "${TARLIST}") If you want to upload it, choose the available resource -(e.g. http://transfer.sh) and run the following command: +and run the following command: $ curl -T ${ARCHIVE} FINALIZE ================================================================================ > > > >  - Manual usage. User can simply pack all necessary artefacts by > running the > >    following command. > >    $ /path/to/${TOOL} -c ./core -d /tmp > > > >  - Automatic usage. If user faces the failures often, one can set > this script > >    as a pipe reciever in kernel.core_pattern syntax. > >    # sysctl -w kernel.core_pattern="|/absolute/path/to/${TOOL} -d > /var/core -p %p -t %t" > > 2. it would be more convenient to set real path to tarabrt.sh in a > usage, see patch below I'll follow Sasha's suggestion and simply use the given script name. Diff is below: ================================================================================ diff --git a/tools/tarabrt.sh b/tools/tarabrt.sh index b484fc9fb..66d6a39d6 100755 --- a/tools/tarabrt.sh +++ b/tools/tarabrt.sh @@ -3,7 +3,7 @@ set -eu TOOL=$(basename "$0") HELP=$(cat < > --- a/tools/tarabrt.sh > +++ b/tools/tarabrt.sh > @@ -2,6 +2,8 @@ >  set -eu > >  TOOL=$(basename "$0") > +#TOOLPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )" > +TOOLPATH=$(realpath -s $0) >  HELP=$(cat <  ${TOOL} - Tarantool Automatic Bug Reporting Tool > > @@ -45,11 +47,11 @@ USAGE > >    - Manual usage. User can simply pack all necessary artefacts by > running the >      following command. > -    $ /path/to/${TOOL} -c ./core -d /tmp > +    $ ${TOOLPATH} -c ./core -d /tmp > >    - Automatic usage. If user faces the failures often, one can set > this script >      as a pipe reciever in kernel.core_pattern syntax. > -    # sysctl -w kernel.core_pattern="|/absolute/path/to/${TOOL} -d > /var/core -p %p -t %t" > +    # sysctl -w kernel.core_pattern="|${TOOLPATH} -d /var/core -p %p -t %t" > >  HELP >  ) > -- Best regards, IM