From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B3ED36FC8F; Fri, 16 Apr 2021 13:59:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B3ED36FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618570757; bh=FAfs87nj1bWaHjZ2jcLf6jFR+QlluJXZRcB2FYPctCA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PSd4SWFSKFoLJ9Pac6Nfw5L9PqdpuF2KVbq4tkOXkKvtiwTCS++4KToHgqZybFp9o z59K2Na0wUQUQB6Q2doowoDoE6XF3QI6pGpJHOGRvKMWWkZWPIpyiufYih+eM2CkjG 5CImyb7slmXbU4AUXL9TTpfCpjOp/fEJ81xtfrI8= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4DF486FC8F for ; Fri, 16 Apr 2021 13:59:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4DF486FC8F Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lXMBv-0008DT-KC; Fri, 16 Apr 2021 13:59:15 +0300 Date: Fri, 16 Apr 2021 13:59:14 +0300 To: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org Message-ID: <20210416105914.GA87368@tarantool.org> References: <93f9710b8ee9b17b023b18dfa09da7e1d566340b.1618570487.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <93f9710b8ee9b17b023b18dfa09da7e1d566340b.1618570487.git.imeevma@gmail.com> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480BE79914FF86F9151AC38CC435EA4A654182A05F538085040B0831B29B6E45B9748B96A8A4263EF74BE2EFD81EA4B000D46C2DDA05E041C9C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70043D879A87EF1BCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371758572763D318798638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2116AE38203B56CC65EECC4490FF858170A05E728617FD226D2E47CDBA5A96583C09775C1D3CA48CFE478A468B35FE767117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE74A95F4E53E8DCE969FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735E4A630A5B664A4FFC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5EDAD99F759D5BC4D66866DC05C3C28E3F0442672B94789C6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34411AA3F52B5778B6035142ECB8AEF16CE65F9809F2E3100D9A9CA495136CD9D9B4A90C3BAEB10F981D7E09C32AA3244CFFB0CEFE137282A07551CA8595C798A195A9E0DC41E9A4CF729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3S6P1v0GIqSZKeFcITrdDw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638224E8F7C1BB4C7A0722F7C583E52DD485583D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/1] Add test and changelog for issue gh-5890 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sorry, I didn't include links to issue and branch in original letter. https://github.com/tarantool/tarantool/issues/5890 https://github.com/tarantool/tarantool/tree/imeevma/gh-5890-changelog-and-test On Fri, Apr 16, 2021 at 01:56:40PM +0300, Mergen Imeev via Tarantool-patches wrote: > --- > ...fix-wrong-result-on-select-with-groupby.md | 4 +++ > ...gh-5890-wrong-select-with-groupby.test.lua | 28 +++++++++++++++++++ > 2 files changed, 32 insertions(+) > create mode 100644 changelogs/unreleased/fix-wrong-result-on-select-with-groupby.md > create mode 100755 test/sql-tap/gh-5890-wrong-select-with-groupby.test.lua > > diff --git a/changelogs/unreleased/fix-wrong-result-on-select-with-groupby.md b/changelogs/unreleased/fix-wrong-result-on-select-with-groupby.md > new file mode 100644 > index 000000000..1ed39ccce > --- /dev/null > +++ b/changelogs/unreleased/fix-wrong-result-on-select-with-groupby.md > @@ -0,0 +1,4 @@ > +## bugfix/sql > + > +* Fix wrong result of SELECT with GROUP BY in case one of selected values is > + VARBINARY, which is not directly obtained from a space (gh-5890). > diff --git a/test/sql-tap/gh-5890-wrong-select-with-groupby.test.lua b/test/sql-tap/gh-5890-wrong-select-with-groupby.test.lua > new file mode 100755 > index 000000000..2b7e19862 > --- /dev/null > +++ b/test/sql-tap/gh-5890-wrong-select-with-groupby.test.lua > @@ -0,0 +1,28 @@ > +#!/usr/bin/env tarantool > +local test = require("sqltester") > +test:plan(2) > + > +-- > +-- Make sure the SELECT result does not change if GROUP BY is used in case one of > +-- selected values is also used in GROUP BY and is a VARBINARY that is not > +-- directly received from space. > +-- > +test:do_execsql_test( > + "gh-5890-1", > + [[ > + CREATE TABLE t(i INT PRIMARY KEY, v VARBINARY); > + INSERT INTO t VALUES(1, x'6178'), (2, x'6278'), (3, x'6379'); > + SELECT count(*), substr(v,2,1) AS m FROM t GROUP BY m; > + ]], { > + 2, 'x', 1, 'y' > + }) > + > +test:do_execsql_test( > + "gh-5890-2", > + [[ > + SELECT count(*), v || v AS m FROM t GROUP BY m; > + ]], { > + 1, 'axax', 1, 'bxbx', 1, 'cycy' > + }) > + > +test:finish_test() > -- > 2.25.1 >