From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 99A066EC5F; Thu, 15 Apr 2021 02:07:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 99A066EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618441632; bh=ampJn5D49SUb69AxuAnAFOVKqoczmUtPCRl2FzkbXg0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ThtEdMgvdsDC6M9ww9FjM/oSZDiW7xv6tsZ+6wslah+cC7eFt4Vn8Ux+bwawQ49CY DcVvH/g05LmJgu9YVuKClpm5G+BmlYCjg5klI+duEgoA41c1saSuQ8J3Za9B10xLLF 4Naj5AzCod7lbtWFS65y9mr16P/EpIyimxlc4M14= Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6D2E56EC5F for ; Thu, 15 Apr 2021 02:07:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6D2E56EC5F Received: by smtp17.mail.ru with esmtpa (envelope-from ) id 1lWobF-0001f9-No; Thu, 15 Apr 2021 02:07:10 +0300 Date: Thu, 15 Apr 2021 02:07:08 +0300 To: Vladislav Shpilevoy Message-ID: <20210414230708.GA307093@tarantool.org> References: <6724ff5d04df88fc611d4f921e6bb0b541cd5863.1617984948.git.imeevma@gmail.com> <3e0e446f-25b9-c904-6f2f-e263913dbe17@tarantool.org> <20210413160916.GA154326@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480EBD5CA77A668ECB87DA2124B0A8E6609182A05F538085040B8E2682341A683F5896272902E1AC4D5B0DBFC24D3BECDC788CAAB50D45E16B0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE746D93DAA4671895CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637160171C9EBC7AFE48638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B29C1C3FEC476DED4A2CE525CF8FEE651A1DC1F2ED7A42611AD2E47CDBA5A96583C09775C1D3CA48CF253F27DA5A70FAF3117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE72B26B6EDD975AFD79FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7B5E3BED0A65F627FD32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C01AB2475877E8919AB3661434B16C20AC9FBD6F3D67178DB4E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B677084C381D43A98D089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831BA3ADA2838E692B3491AA492AB43C9A7 X-C1DE0DAB: 0D63561A33F958A58323CD1D436F905F02A8C4B6BA830394652EA210055B5DC4D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3435B1F14A93C4073F8F5A8B18CB6C0D8EC44156D6BBA8F33E879EC9E474CC780FFE039D586C5E3ED21D7E09C32AA3244C4CBFFC8FCE40AEDC3A2806AE71ED8BD4C3B3ADDA61883BB5FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrcJA+pXcDukm2WRwrPalhw== X-Mailru-Sender: 5C3750E245F362008BC1685FEC6306EDA155CF9A8AB959C2896272902E1AC4D538066306E4938E9F5105BD0848736F9966FEC6BF5C9C28D97E07721503EA2E00ED97202A5A4E92BF7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 12/52] sql: introduce mem_is_*() functions() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! My answer below. On Thu, Apr 15, 2021 at 12:48:34AM +0200, Vladislav Shpilevoy wrote: > Thanks for working on this! > > > diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h > > index 82b3084fb..041d8a414 100644 > > --- a/src/box/sql/mem.h > > +++ b/src/box/sql/mem.h > > @@ -87,21 +87,6 @@ struct Mem { > > */ > > #define MEMCELLSIZE offsetof(Mem,zMalloc) > > > > -/** > > - * Return a string that represent content of MEM. String is either allocated > > - * using static_alloc() of just a static variable. > > - */ > > -const char * > > -mem_str(const struct Mem *mem); > > - > > -/** Initialize MEM and set NULL. */ > > -void > > -mem_create(struct Mem *mem); > > - > > -/** Free all allocated memory in MEM and set MEM to NULL. */ > > -void > > -mem_destroy(struct Mem *mem); > > Why did you move them? They were just introduced in the previous > commits. Actually, I moved MEM_Flags since they should be defined before mem_is_*() functions. Looks like for git moving these functions were more appropriate solution.