Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 luajit] tools: introduce --leak-only memprof parser option
Date: Wed, 14 Apr 2021 17:34:53 +0300	[thread overview]
Message-ID: <20210414143453.GA29703@tarantool.org> (raw)
In-Reply-To: <20210331172948.10660-1-skaplun@tarantool.org>

Sergey,

I've checked the series into tarantool branch in tarantool/luajit and
bumped a new version in master.

On 31.03.21, Sergey Kaplun wrote:
> This patch indtroduces new memprof parser module <process.lua> to
> post-process memory events.
> 
> Memprof parser now adds postamble with the source lines of Lua chunks
> (or "INTERNAL") that allocate and do not free some amount of bytes, when
> profiler finishes. The parser also reports the number of allocation and
> deallocation events related to each line.
> 
> Also, this patch adds a new --leak-only memory profiler parser option.
> When the parser runs with that option, it reports only leak
> information.
> 
> Resolves tarantool/tarantool#5812
> ---
> Changes in v2:
> * introduce new memprof's <process.lua> module to post-process parsed
>   events
> * add tests
> 
> ChangeLog entry (and postamble too Tarantool bump commit message):
> 
> ===================================================================
> ##feature/luajit
> 
> * Now memory profiler parser reports heap difference occurring during
>   the measurement interval. New memory profiler's option `--leak-only`
>   to show only heap difference is introduced. New built-in module
>   `memprof.process` is introduced to perform memory events
>   post-processing and aggregation. Now to launch memory profiler
>   via Tarantool user should use the following command:
>   `tarantool -e 'require("memprof")(arg)' - --leak-only /tmp/memprof.bin`
> ===================================================================
> 
> Branch with tests and added the corresponding built-in:
> * https://github.com/tarantool/tarantool/tree/skaplun/gh-5812-memprof-memleaks-option
> LuaJIT branch:
> * https://github.com/tarantool/luajit/tree/skaplun/gh-5812-memprof-memleaks-option
> Issue: https://github.com/tarantool/tarantool/issues/5812
> 
>  .../misclib-memprof-lapi.test.lua             | 21 +++++--
>  tools/memprof.lua                             | 33 ++++++-----
>  tools/memprof/humanize.lua                    | 43 +++++++++++++-
>  tools/memprof/parse.lua                       | 20 +++++--
>  tools/memprof/process.lua                     | 59 +++++++++++++++++++
>  5 files changed, 151 insertions(+), 25 deletions(-)
>  create mode 100644 tools/memprof/process.lua
> 

<snipped>

> -- 
> 2.31.0
> 

-- 
Best regards,
IM

      parent reply	other threads:[~2021-04-14 14:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 17:29 Sergey Kaplun via Tarantool-patches
2021-04-08 12:49 ` Sergey Ostanevich via Tarantool-patches
2021-04-14 11:32   ` Sergey Kaplun via Tarantool-patches
2021-04-13  7:43 ` Igor Munkin via Tarantool-patches
2021-04-14 11:31   ` Sergey Kaplun via Tarantool-patches
2021-04-14 13:12     ` Igor Munkin via Tarantool-patches
2021-04-14 14:34 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414143453.GA29703@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 luajit] tools: introduce --leak-only memprof parser option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox