From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B918B6B962; Wed, 14 Apr 2021 02:34:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B918B6B962 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618356848; bh=FsYwDJkL0+6TlV5ILWpsYr4TPRNy11XdcbW2zzjU3K4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nW9rNbQXwcMdSGdFt2n0GEiL9ZSiSTQ1/4nQ2rGpPnroLZ1M4nbQTcF7mQpD6fG+o tOgwyAmOcgkNslT4f6U2JC0bdnKEQgjfGntmYnAEuAm4zPdNSswMWcKweFkJ0UF+TH Bv7NwzlZ85ENF6LYKOONM11c8ikqn0F0eoeYGDzA= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C6B876EC5B for ; Wed, 14 Apr 2021 02:34:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C6B876EC5B Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1lWSXm-00040k-13; Wed, 14 Apr 2021 02:34:06 +0300 Date: Wed, 14 Apr 2021 02:34:04 +0300 To: Vladislav Shpilevoy Message-ID: <20210413233404.GB91501@tarantool.org> References: <3fda2029b186d0cea67ba01269dc3d6e209b3c89.1617984948.git.imeevma@gmail.com> <57dd6994-64f3-7645-f0ec-376751bd0b3e@tarantool.org> <20210413120116.GA95443@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480257C85EA0BB7A95D0F00AE41BB9A5343182A05F538085040C2936EC7ED67135AD3A1F387184D89F9C517A65889A6CAFCBCDCC8D5B0E19DC5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AED985C8E545F588EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D4360D888D8F9BE48638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B255B5915E1B192FEC4F7C027531D168122CC0D3CB04F14752D2E47CDBA5A96583C09775C1D3CA48CF17B107DEF921CE79117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7E6CE9E486478CC59D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0E529F61BD1BD0CC1CD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C332C16DEEF884694935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4ADD69086D7A80F17D366ED7E3CE7AA2139 X-C1DE0DAB: 0D63561A33F958A5B46772EC6C0411C52ACA5B5E98CDCF44E2D617690C698A5CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D6AC337C1E637B8AE11915CB8F0CA57B507F404E385D3A1A173123C7BA6404EB0A8CD714FD2F5F511D7E09C32AA3244C451EF8D1533F20D9D07156E8AEA51CBE6C24832127668422FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnA7/qPBUIXGFK0Ve7wTmJg== X-Mailru-Sender: 5C3750E245F362008BC1685FEC6306ED288EF40B8884D909D3A1F387184D89F9F7F5837242FA16B25105BD0848736F9966FEC6BF5C9C28D97E07721503EA2E00ED97202A5A4E92BF7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 01/52] sql: enhance vdbe_decode_msgpack_into_mem() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thank you for the review! On Wed, Apr 14, 2021 at 01:22:34AM +0200, Vladislav Shpilevoy wrote: > Good job on the patch! > > On 13.04.2021 14:01, Mergen Imeev wrote: > > Thank you for the review! I'a sorry to ask you so late, but could you look at > > new version of the patch? It was decided that this patch should be pushed to > > 2.6 and 2.7 along with master. Only this patch of the patch-set. > > I think the entire patchset must be pushed to all versions. Otherwise you are > going to have hard time to cherry-pick anything from the master branch. > I will ask about this tomorrow. > Additionally, what about > > sql: rework vdbe_decode_msgpack_into_mem() > > ? It also fixes a bug. > True. I knew that it fixes a bug, but didn't thouth about the fact, that it possibly won't be pushed to 2.6 and 2.7. For now I do not know what to do about this patch. I will ask about this also. > On the branch I see the entire patchset, not just this commit. Is it > intended? > Yes, it is. I did not split this commit from patch-set, for now. > > This commit LGTM.