From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CB3DC6BD18; Mon, 12 Apr 2021 09:04:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CB3DC6BD18 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618207464; bh=cMAX7UGPyyz5DAubQJCbIkEbA1C+E8Qc+bi+u4Oy+bI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=emMZTEkLgoeRqIBZkf4q7nSzv7IgtpEH9Em4al9Rt/ThohXz+tpYnLRB2APuBsA0s uMqyKc5/a86NJhFUBQvGvB3ybyRhhq4HTguH3tUsD1Wq2EY5yVwn8fIeA6LG5x6Gxf 7zjMiRT0rJpZsrchASMYa7JMbG1tMZ7koOJAHDl8= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F017A6EC5B for ; Mon, 12 Apr 2021 09:04:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F017A6EC5B Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1lVpgN-00076A-2V; Mon, 12 Apr 2021 09:04:23 +0300 Date: Mon, 12 Apr 2021 06:04:22 +0000 To: Vladislav Shpilevoy Message-ID: <20210412060422.ufnvloajy6j3oz5z@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480EBD5CA77A668ECB87DA2124B0A8E6609182A05F5380850403091F66CBE4127DA2C494A6DFCBD2885074C4678C00F32412537499C9E098D11 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE711269A7C2F827F16EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375C4806A08D329A618638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B26FB3859E1B086970AB76812485E5DDB316A3AA18C56759C2D2E47CDBA5A96583C09775C1D3CA48CFCF36E64A7E3F8E58117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE709B92020B71E24959FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE75C623DA9A09669397B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050F1E561CDFBCA1751FE21AE983DBD7FFC1B3661434B16C20AC78D18283394535A9E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6EF52EB61805CD9BF089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C978317EC2CEA6230ECD74AB73A7D1547457A7 X-C1DE0DAB: 0D63561A33F958A5C24702040E9672E6C242CC535C4B1159C905DCD44562056CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340FE9920E7E3E5C62379913F077B82C1069726C9FC0FA38F6352C53932A2980D1A8E3C39D0DE8B09B1D7E09C32AA3244CD285C0BC8C9421FC05EC7108F2ADE3D6F2F5F14F68F1805B927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojq8JA+pXcDulwdieGssp1AQ== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD23DCA8E5B2B22B46A24BC8647E7D4C82797AF23EEB7B65FE8CA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 0/5] send feedback on start and on key events X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Cc: alexander.turenko@tarantool.org, tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 11 апр 16:15, Vladislav Shpilevoy via Tarantool-patches wrote: > Thanks for the patchset, Sergey! Technically the patchset looks bearable. > Below text is for the people who forced us to do this ticket. > > > Disclaimer: this is not toxic. I mostly just ask questions and express > my opinion. > > I don't like the patch. The hack to workaround some CI issues with a sleep, > and the behaviour we introduce on the whole. I don't think creation of a > first space/index makes any sense to track. > > The reason about "going through a tutorial" is a very weak argument. Spaces > are created not only as a part of a tutorial obviously. And I see no other > reason for sending these "events". > > This rant is for Mons, Artur, and whoever else pushed sending of that useless > information and introduction of a **known bug** which we hack with 10s sleep. I > bet they have no idea how to really use it **exactly**, not in some abstract > way they will try to figure out later, and they just wanted to send "something" > to close some story-points. > > We on purpose **push buggy code** only to send these feedback events we don't > know what to do with. > > Here is what I see in the issue: > > In order for us to assess the real situation for the product, it is > necessary to send feedback from the product immediately after the > launch and after the key actions are completed. > > How the hell is it related to a "real situation for the product"? How is it > "necessary"? What was wrong with the feedback we have now? How are the > instances working less than 1 hour are so important? And why do you need to > know exactly when a first space/index was created? Well, even if we need it, > we could remember the timestamps and send them with the next regular report. > > Another cite: > > If Tarantool was installed using a script from the Download page, > then you need to send feedback immediately and further after the > following events are completed: > > ... > > The rest of Tarantool that were downloaded outside of the Download > page does not contain a special meta-file and should be considered as > internal usage and no feedback sent from them. These are usually CI > instances. > > What is that "metafile"? We send the feedback anyway regardless of some metafile > in this patch, and from where the executable file was downloaded. Which again > renders this "feature" absolutely useless. Besides, creation of a first index > and space won't cover instances which don't create any indexes and spaces. For > example, vshard routers. > > Additionally, implementation of this code stole time from the scaling team on > writing the code, doing the reviews, doing the review fixes. How is it even > related to the scaling team at all? Why was it so urgent and more important than > finishing a fix for a serious bug in the synchronous replication? I would propose > Artur to send a PR for that next time. Tickets like that should go to the > wishlist right away, instead of the known crashes and optimizations. > > I hope we will drop these feedback events in the future when will realize it > does not help anyhow with a problem which can't even be properly formulated, > and because it introduces a bug we don't know for sure why is happening, and > how can be fixed except the 10s sleep hack. This was our commitement, so it should be done. I'll escalate this to our PMs. -- Regards, Kirill Yukhin