Re: [Tarantool-patches] [PATCH] luajit: bump new version

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sasha,

Thanks for your review!

On 06.04.21, Alexander V. Tikhonov wrote:
> Hi Igor, thanks for the patch, as I see no new degradation found in
> Github Actions testing commit criteria [1], patch LGTM.

Added your patch:
| Reviewed-by: Alexander V. Tikhonov <avtikhon@tarantool.org>

> 
> [1] - https://github.com/tarantool/tarantool/tree/imun/gh-5959-fix-dynamic-modules-loading-on-macos
> 
> On Mon, Apr 05, 2021 at 08:22:47PM +0300, Igor Munkin wrote:
> > LuaJIT submodule is bumped to introduce the following changes:
> > * test: fix dynamic modules loading on MacOS
> > * test: make utils.selfrun usage easier
> > * test: remove excess dependency for tests target
> > 
> > Within this changeset SIP issues are worked around and dynamic modules
> > loading on MacOS is fixed. As a result LuaJIT tests can be enabled for
> > static build target on MacOS.
> > 
> > Closes #5959
> > Follows up #4862
> > 
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---
> > 
> > Honestly, this patch is sent mostly to inform our QA master that as a
> > result of LuaJIT-related patch our CI finally runs LuaJIT tests for all
> > existing testing pipelines.
> > 
> > Issue: https://github.com/tarantool/tarantool/issues/5959
> > Branch: https://github.com/tarantool/luajit/tree/imun/gh-5959-fix-dynamic-modules-loading-on-macos
> > LuaJIT-related series: https://lists.tarantool.org/tarantool-patches/cover.1617641697.git.imun@tarantool.org/T/#t
> > 
> >  .travis.mk         | 11 +----------
> >  third_party/luajit |  2 +-
> >  2 files changed, 2 insertions(+), 11 deletions(-)
> > 

<snipped>

> > -- 
> > 2.25.0
> > 

-- 
Best regards,
IM