From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 10D956EC5D; Tue, 6 Apr 2021 23:40:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10D956EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617741655; bh=Njdep2K8q52oJkBiVgmiQDjG5qp2HU8QmC6P/RM6QvY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=g9CkrqzIO+3yDpgsdzhVOfmhLR5W1kUGCCJZ6mines73IJ9Agn9heUIuNtBX7JCtb 6WBci42MMBecCaXrxbcH8OqtSnEH0KH07OMdQxl1enOge2aJClHTlwTpTIoAVFu7tG 9+pRJ3jdQflqhOJHurpx+cvNXPYd/zXC0YTjgwmo= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CE86A6EC5D for ; Tue, 6 Apr 2021 23:40:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CE86A6EC5D Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lTsVI-000795-T3; Tue, 06 Apr 2021 23:40:53 +0300 Date: Tue, 6 Apr 2021 23:40:42 +0300 To: Sergey Kaplun Message-ID: <20210406204042.GJ29703@tarantool.org> References: <0bf0dc418d1095fc5c8d3901469662c853fb93de.1616743343.git.skaplun@tarantool.org> <20210330221506.GV29703@tarantool.org> <20210406200900.GI29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210406200900.GI29703@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC1FEA0A53B931EDD909DE4D58F47F062C400894C459B0CD1B91EF2D1B79960233254EE6F5254886D31F539346F7DC78739DBD6ABFBCFC3BAB6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E628FE8A185FCFBEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374F897F3E43A934888638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCDC7508B97B26DEC1BDBD9F307D8BBB7A54DDC4C6455741F7389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C39472471D10B198B935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831D75FEFD994F035D1D78DE17948D3915F X-C1DE0DAB: 0D63561A33F958A541A9F19B3C682342DFBF40F1889BBC30874A7BE24A5DF241D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34505665BFD4C70705300CDB889BC80141F2D132B62C26A756E9636CBB1ACA34217B35AF061AAC4D8B1D7E09C32AA3244CEDCE2965085176F33EE41E6481C1468B6C24832127668422927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAX27rRizpLneTTQQZdDXYA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822E660E3F322B138F648DD0BD05278A544A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 11/30] test: adapt getlocal PUC test for vararg func X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 06.04.21, Igor Munkin wrote: > Sergey, > > On 01.04.21, Sergey Kaplun wrote: > > Igor, > > > > Thanks for the review! > > > > On 31.03.21, Igor Munkin wrote: > > > Sergey, > > > > > > Thanks for the patch! I can't understand why this patch is separated > > > from the previous one. Could you provide a rationale for this, please? > > > BTW as we discussed before: s/Closes/Resolves/, considering your changes > > > on the branch. Also consider the comments below. > > > > The root reason of the previous patch is about counting of local > > variable in caller. Here this local variable is used for counting > > arguments amount. > > OK, now I get it. Let's then squash 11 and 16 patches, since they solves It's a typo: s/16/20/ while reading please. > the one problem and leave 10 as is, since it fixes a different one. BTW, > I'm even fine if you leave everything as is. So, here is my LGTM and > feel free to adjust these patches on your own. > > > > > > > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, IM