From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6B4166EC5D; Tue, 6 Apr 2021 23:09:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6B4166EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617739753; bh=Pgco8N7xYA3gCB8WZ2/VsJWKjDgURyt+89nJcXr8EJs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tsasa8rPfFwblu8WUcPKyBpIAu9efid/o6EJNintWGCwJ0salY1fPCIuc7VWrUAKk EJmIEyxBd0SLCHDVAqJm2TiY5/tWhzMPOqXqMsl6ogdFNOB1kPso9vqj9p4uRwG91P TC4KWipMPhgkQW1rhOrPIfuPSu+WTb/Qt2/AwkEY= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 11DB06EC5D for ; Tue, 6 Apr 2021 23:09:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 11DB06EC5D Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lTs0d-0003ps-8F; Tue, 06 Apr 2021 23:09:11 +0300 Date: Tue, 6 Apr 2021 23:09:00 +0300 To: Sergey Kaplun Message-ID: <20210406200900.GI29703@tarantool.org> References: <0bf0dc418d1095fc5c8d3901469662c853fb93de.1616743343.git.skaplun@tarantool.org> <20210330221506.GV29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC1D02DAB0F9DED067BCD1A4941321F7F2200894C459B0CD1B926EF827CE1A54DC840B6C94B00998355DD3D62A25EE111B7E18382D0F8725956 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7235646FAB97B4BEDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D071468F2F69688EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C41474C4412709CBB458F1BEFD266042B136AEFCC7A5FCAE99FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B3A703B70628EAD7BA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C5BAEAC3434B06E9C43847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783114741DC785E427D97892AAF64C174D19 X-C1DE0DAB: 0D63561A33F958A5A8F5AE24076AF475625D9E30D282F65E9B204323BABF1CF6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A58BF0C7EAC340F55807678D92AD1C2958BF642D7CD239DD09D169DD47EF05D174117BE73AA9E7F1D7E09C32AA3244CC9041F4FC0DD4C3603761767AA4D1B1B35DA7DC5AF9B58C0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAX27rRizpLmWGyIdnlgzgg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822A77330C53353D1A73F151D0C4E35EB29A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 11/30] test: adapt getlocal PUC test for vararg func X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 01.04.21, Sergey Kaplun wrote: > Igor, > > Thanks for the review! > > On 31.03.21, Igor Munkin wrote: > > Sergey, > > > > Thanks for the patch! I can't understand why this patch is separated > > from the previous one. Could you provide a rationale for this, please? > > BTW as we discussed before: s/Closes/Resolves/, considering your changes > > on the branch. Also consider the comments below. > > The root reason of the previous patch is about counting of local > variable in caller. Here this local variable is used for counting > arguments amount. OK, now I get it. Let's then squash 11 and 16 patches, since they solves the one problem and leave 10 as is, since it fixes a different one. BTW, I'm even fine if you leave everything as is. So, here is my LGTM and feel free to adjust these patches on your own. > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM