From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A592F6EC5D; Tue, 6 Apr 2021 11:03:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A592F6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617696188; bh=w5KylV5Ivtuh07g/rCUAuu0GBa1hP1c1UjoQB2JddOk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Zl/WNHPHONEX+NGAJhBI1xPoJOv8TA5c859vCAG/3LhTqKkgtcEGFt8C7X0YZp7a4 jrAo8cpY12E3ykmAUvS2ECGzzFvIcUxPENYVNy9NiJE6YoENQL3TPsJmrmvCOxwbnL Tj7TJAygUdLCWxeKYm17dBFkUzeY9dqhjVP0yGWE= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 131A96EC5D for ; Tue, 6 Apr 2021 11:03:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 131A96EC5D Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lTgfy-0002Tx-Mz; Tue, 06 Apr 2021 11:03:07 +0300 Date: Tue, 6 Apr 2021 11:02:56 +0300 To: Sergey Kaplun Message-ID: <20210406080256.GA29703@tarantool.org> References: <0f14e772231484f8ed786e499ac62be28dd2a484.1617641697.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294CA3588DDE0233B0D17711AF1EA2D7DB9182A05F5380850403A3F4F68D7CF06FC59AA3115992EDD581C2D2304A29A70F540AF65C636418279 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74FF5DF51D335CFFFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D038D3D3B22CF2FA8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C16EE06F5A270FE6AAC7F6DE5CF73F18DAD50E5EE5E8136A8A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D699F3A2029486C7731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5A0FEA85696DC3810BA2D3A3CD4DD56864EFDB48709BF6985D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3444047AE358B40754720B7DBC2F89CCC66887022604D1261025F05455AD1381C62F36B340F2439D771D7E09C32AA3244C75C7EE7446B1423756DBC0A177F621428580396430872480927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojM00ve/f+0onYLWXga4Zlyg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638222ECD989930444BF2DB0C57B0065D947CA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: remove excess dependency for tests target X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 06.04.21, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > > LGTM, except a few nits below. Added your tag: | Reviewed-by: Sergey Kaplun > > On 05.04.21, Igor Munkin wrote: > > Nit: I propose the following commit title rewording: > | test: remove excess dependency for tarantool suite > Feel free to ignore. I was thinking a lot about this commit subject and was so close to the one you proposed, but I afraid it can misguide the reader: I tried to emphasize, that we removed the *target prerequisite* (in terms of GNU Make), but from yours it looks we removed the suite dependency. Changed "dependency" to "prerequisite" to follow GNU Make terms. > > > TEST_DEPS list was introduced to prevent target from > > being run in case no dependencies are changed. As a result of review it > > Typo: s/result of review/result of the review/ Fixed. > > > was decided to make all *-tests targets be .PHONY rules, hence TEST_DEPS > > Typo? "be" looks excess here. I propose the following rewording No, it's not, but changed to yours if it makes the sense clearer. > | As a result of the review it was decided to turn all *-tests targets > | into .PHONY rules, hence TEST_DEPS variable is excess and can be > | dropped. Here is the final wording: ================================================================================ test: remove excess prerequisite for tests target TEST_DEPS list was introduced to prevent target from being run in case no dependencies are changed. As a result of the review it was decided to turn all *-tests targets into .PHONY rules, hence TEST_DEPS variable is excess and can be dropped. Follows up tarantool/tarantool#4862 Reviewed-by: Sergey Kaplun Signed-off-by: Igor Munkin ================================================================================ > > > variable is excess and can be dropped. > > > > Follows up tarantool/tarantool#4862 > > > > Signed-off-by: Igor Munkin > > --- > > test/tarantool-tests/CMakeLists.txt | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > > index 9bb26f32..3e36ff86 100644 > > --- a/test/tarantool-tests/CMakeLists.txt > > +++ b/test/tarantool-tests/CMakeLists.txt > > @@ -69,7 +69,6 @@ set(LUA_PATH > > ) > > set(LUA_TEST_SUFFIX .test.lua) > > Nit: looks like `LUA_TEST_SUFFIX` variable is excess now, and we can > move suffix ".test.lua" to `--ext` flag directly. I don't think so. Considering your comment we need to drop every variable that can be used in-place :) > Feel free to ignore. Ignoring. > > > -- > > 2.25.0 > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM