From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8938A6EC60; Thu, 1 Apr 2021 02:00:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8938A6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617231635; bh=sb6Em3U6+/TPWVp+YHqn7/UfC5CW78kfBeS7iFBhwcU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Tcm42bi0KkfYlauwH4dVJSzQk+dxvXuZIJcg+R/cJKIqEb5Qc1zU7nIWcXBNV3D7Z 9HKIg7UUXyvCM2PrpRqVlIe3CdEy3Ki5jMp47YmqnFaQW6zHtZEEi7jEJlWOXthoXI P9MPHdAA2qCR0EMJD8D3NDTAjMExN45mfVeWTxrU= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB05B6BD00 for ; Thu, 1 Apr 2021 01:59:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EB05B6BD00 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRjnn-0008Rz-3z; Thu, 01 Apr 2021 01:59:07 +0300 Date: Thu, 1 Apr 2021 01:58:57 +0300 To: Sergey Kaplun Message-ID: <20210331225857.GX29703@tarantool.org> References: <05d8289981e0933402c01659b6785a309d289036.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <05d8289981e0933402c01659b6785a309d289036.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F5380850405C0A436D75E821855091DAC31315EE5F8EBD18431D7C583EB8D2FF9FBA81D50F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3DED2DACB82E709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664933EBC20BCBBD1D83BFB1EA0E7BAC4314F46C10ADF7E7260389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE6371089D37D7C0E48F6C8AA50765F7900637208CF2B091E309D5EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831D2B5125A4351B8200C4CD27AEC68174C X-C1DE0DAB: 0D63561A33F958A5DE39059BFE24B1111BC660B59A837603325B5BACEAA8B8C5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3430FC2BC1B917F018970D9DA129871F88224EB1FE69BB903A6F5077B250B2B2BEE7CAADB53D231D701D7E09C32AA3244CDC2932D2130A1547411B0E3B1A0283348580396430872480927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20J2iK5y8FF1HQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638227779D47DB7993D1E20607B42E21FCB06A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 06/30] test: disable PUC Lua tests confused by -v output X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. On 26.03.21, Sergey Kaplun wrote: > Version and status are printed in stdout instead stderr since Typo: s/printed in stdout/printed to stdout/. Typo: s/instead stderr/instead of stderr/. > LuaJIT-2.0.0-beta11 (as it is not an error message). > See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > (Print version and JIT status to stdout, not stderr.). > This behavior is the same as in Lua 5.2. > > This patch disables tests confused by unexpected -v output to stdout. > > Relates to tarantool/tarantool#5687 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/main.lua | 28 ++++++++++++++++++++-------- > 1 file changed, 20 insertions(+), 8 deletions(-) > > diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua > index c11a576..56f56a0 100644 > --- a/test/PUC-Lua-5.1-tests/main.lua > +++ b/test/PUC-Lua-5.1-tests/main.lua > @@ -103,26 +103,37 @@ prepfile[[ > RUN("lua - < %s > %s", prog, out) > checkout("1\tnil\n") > > +-- Version and status are printed in stdout instead stderr since > +-- LuaJIT-2.0.0-beta11 (as it is not an error message). Typo: s/printed in stdout/printed to stdout/. Typo: s/instead stderr/instead of stderr/. > +-- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > +-- (Print version and JIT status to stdout, not stderr.). > +-- This behavior is the same as in Lua 5.2. > +-- In Lua 5.2 this feature was introduced via commit > +-- 9e7de9473c65baee1f567852a778f2d33a47ea83. > +-- See also https://github.com/tarantool/tarantool/issues/5687. > -- > 2.31.0 > -- Best regards, IM