From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D79736EC60; Thu, 1 Apr 2021 01:59:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D79736EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617231574; bh=ZvnQa8dOMwKmOrdamOH4NSSbq4vsCbR9akPuqYVxAMM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PGsCHmRZfYB8w/5cWU/gEvodwaN7EcPnzgvCtSRnxjwJuGnmkB9LCNRv9dcPYYl5y mnowbqF/hS8sDqFDDaKHBEm/gDc4cO9UgkWj5Tg1ZR7z5mViP5K/LqNZJjRuFfNXJt c8o7k3Nzu/ANKpdlS8gr9ogEW070W/HZgOVfo13c= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D20096EC60 for ; Thu, 1 Apr 2021 01:58:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D20096EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRjnU-0008Lw-U3; Thu, 01 Apr 2021 01:58:49 +0300 Date: Thu, 1 Apr 2021 01:58:39 +0300 To: Sergey Kaplun Message-ID: <20210331225839.GV29703@tarantool.org> References: <5c12f508e83fb3a7191de7d24799ca3e072bf4c2.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5c12f508e83fb3a7191de7d24799ca3e072bf4c2.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F5380850407F85A278D2A8F22496626353788F0C9B7C00F29AB02AF6509B53453ED7D24AB4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371A00CE7BDCE207EB8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFA474A6CCB36BA709609F092349B197DEA471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658359CC434672EE6371117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B58781B77DE60D36C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831D2B5125A4351B820294F1ADDE986B152 X-C1DE0DAB: 0D63561A33F958A55A7CC7D92E09AA485DF7AC7F103B514136D89D138D499779D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC632F0BE69382F3557DD97616257C7E75B2A2E6232F01D6E6FF1B18559F0423F3874A9A9AE3C83F1D7E09C32AA3244C6C7214385AB49F94528A5A69A8FC75096C24832127668422927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20Kc9QQo/DoCOw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822954AEE9948859146371EF4780852D853A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 04/30] test: remove quotes in progname from X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. On 26.03.21, Sergey Kaplun wrote: > When LUAJIT_TEST_COMMAND extend the least `arg` with Typo: s/LUAJIT_TEST_COMMAND extend/LUAJIT_TEST_COMMAND extends/. Typo: s/the least `arg`/the least `arg` slot/. > some string containing double quotes, bash failed to exec this Minor: I believe you're not talking about bash here, but rather about and hence system(3) command, IIRC. > command for child test. > > This patch removes edged '"' to be able run extended command Minor: I guess "framing" fits better than "edging". Typo: s/to be able run extended/to be able to run an extended/. > containing '"' and run other test suites. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/main.lua | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua > index f520896..4f8b8bf 100644 > --- a/test/PUC-Lua-5.1-tests/main.lua > +++ b/test/PUC-Lua-5.1-tests/main.lua > @@ -11,7 +11,9 @@ out = os.tmpname() > do > local i = 0 > while arg[i] do i=i-1 end > - progname = '"'..arg[i+1]..'"' > + -- LuaJIT: remove edged '"' to be able run extended command Minor: I guess "framing" fits better than "edging". Typo: s/to be able run extended/to be able to run an extended/. > + -- containing '"' and run other test suites. > + progname = arg[i+1] > end > print(progname) > > -- > 2.31.0 > -- Best regards, IM