From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6960E6FC8B; Thu, 1 Apr 2021 01:59:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6960E6FC8B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617231544; bh=wF66EdDKI71At6k4+l+WxmoorqB56PFFqThds1EQLwc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BJhBTPMZR2riVXenrIH6wOBM3w9fU0LdMghmbWb60L5BnSUklp40yziC/prTN4M4i McFj4CM7a55Co2uKcWLfgNAwsGTXSKA0vvyfXdvDQiW3bKYkKwLAa6BinpgGRQbsvM keR+yxiTKRYw+4kl+6lpDynOZNEVSV6he/1oP8pA= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 41C916FC8B for ; Thu, 1 Apr 2021 01:58:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 41C916FC8B Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lRjnL-0007ay-Ax; Thu, 01 Apr 2021 01:58:39 +0300 Date: Thu, 1 Apr 2021 01:58:29 +0300 To: Sergey Kaplun Message-ID: <20210331225829.GU29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4F844F00D7AFD5C3C182A05F53808504044500DE852596B78D192793F4606E1BE64F4F019801CAE0FACA7A1CDD9782352 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372A1456D053D20C618638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF525A912932709C568CEE33E8674966F3A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7328B01A8D746D8839FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F790063735872C767BF85DA227C277FBC8AE2E8B38189D631E94611675ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831D2B5125A4351B820B59FADFEE23B5201 X-C1DE0DAB: 0D63561A33F958A58C3F305CF1CBF7FA4672B592CC8A97498F9AF27C0BEA2336D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3475AE8838CC1BF58E2892BCC08CF9E503C0386C19DC92C1D745DFDC536C3B5C773781A0AE36CC87A41D7E09C32AA3244CCC69651ED621EC998FD63612B70175A0F26BFA4C8A6946B8927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20LL4o9n5jL1gg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638226FCA5AB0A945E36458929ADD576E0EC7A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 03/30] test: adapt Lua 5.1 suite for out-of-source build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 26.03.21, Sergey Kaplun wrote: > Hi! > > Thanks for the review! > > On 26.03.21, Sergey Ostanevich wrote: > > LGTM, just minor changes to commit message. > > > > Sergos > > > > > > > On 26 Mar 2021, at 10:42, Sergey Kaplun wrote: > > > > > > When tests are run out-of-source redefined `dofile()` function > > ^ I had problem reading here the > > ‘out-of-source redefined’. Can you put the ‘when..’ to the appropriate > > place at the end of the sentence? ’The redefined … when … ‘ > > Fixed. > > The new committ message is the following (branch is force-pushed): But what is fixed in the new version? I see the sentence Sergos asked to reword is left intact. > > =================================================================== > test: adapt Lua 5.1 suite for out-of-source build > > When tests are run out-of-source redefined `dofile()` function failed to > find the test file to load. So, fullpath is detected considering > `arg[0]` value. Moreover, some tests use `loadfile()` instead, so their > argument is adjusted to the full path to the files. > > However, test in creates a temporary file > and executes it via `dofile()` too, so this case is handled by > the second argument -- `prefix` equals an empty string for > current working directory. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > =================================================================== > > > > > > failed to find file to load. So, fullpath is detected considering > > > `arg[0]` value. Moreover, some tests use `loadfile()` instead, so > > > their argument is adjusted to the full path to the files. > > > > > > However, test in creates a temporary file > > > and executes it via `dofile()` too, so this case is handled by > > > the second argument -- `prefix` equals an empty string for > > > current working directory. > > > > > > Part of tarantool/tarantool#5845 > > > Part of tarantool/tarantool#4473 > > > -- > > > 2.31.0 > > > > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM