From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 28FDF6EC60; Wed, 31 Mar 2021 22:27:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 28FDF6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617218872; bh=Kv9Ls0uY05+LyDs3lju5aH3absohkn6Y8lVaaUXFzAg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=W+UHoK9brm9zQlITid81syO4ZER4L0JYYbESG6Z9tbY6AGMFA4aMm0KcQAyW8Jcvm fNjVzBrSNAcdzqCkBVVdqY3AYZSLX566WvnRcAFyyNDR67dgccvxGKiUKTT8ckOynC vO8BIT4LIFP0Tcfu9qyCN6E5mlfSt8AZFZjZ3I/I= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 798466BD04 for ; Wed, 31 Mar 2021 22:24:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 798466BD04 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRgSS-0003YH-Nc; Wed, 31 Mar 2021 22:24:53 +0300 Date: Wed, 31 Mar 2021 22:24:43 +0300 To: Sergey Ostanevich Message-ID: <20210331192443.GR29703@tarantool.org> References: <08EA62DA-054B-44AD-852B-4EFA40C457B1@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <08EA62DA-054B-44AD-852B-4EFA40C457B1@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294CA3588DDE0233B0D17711AF1EA2D7DB9182A05F538085040EEA9F4F885FACD870F56A06AA5B62CBE0496E25BD8D07CBAB4D9806F0D95E51C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7876E9C5582D2D91DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637782358EF9635990EEA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664BBEFA4ED06CA03A75FD0AA8196B9796036D191BCBD47C2F0389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92A417C69337E82CC2CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F0FC70B58D375E76A35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A520E9196D98F16B6FA4929A2EC7EFCAC8880982C61FB26B97D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D9DC20663B80603F1BC165F6DEA31566B87A44C5556139631A9681DE8C662B42722232B8C382AFF81D7E09C32AA3244CF9F6BD91465432EBC03BFBF211947374A8CE788DE6831205927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20Iz1a9H2MglQg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822EE67FDF8E3C9741E49B30C2F5DC1CBFEA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 29/30] test: disable PUC Lua hanging GC test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergos, On 26.03.21, Sergey Ostanevich wrote: > Can it be more relevant fix s/1000/n+1000/ for these two loops? > > Although I start talking about an in-place fix, rather than a follow-up. If you're talking about some constant value, then this solution is still fragile: one can introduce a new Lua objects in Tarantool builtins and the test is broken again. However, if you're talking about saving the value yielded by "collectgarbage('count')" call after the series of collectgarbage('collect') calls and use 1000 as a *relative* memory growth, then it looks like a nice follow-up patch. Or Sergey can do it in this series if he wants to. > > LGTM. > Sergos > > > On 26 Mar 2021, at 10:43, Sergey Kaplun wrote: > > > > Tarantool has too many objects at start. `gcinfo()` result is always > > greater than 1000 expected by the test. It leads to infinite loop in the > > test. > > > > This patch disables GC test leading to hanging for Tarantool binary. > > > > Part of tarantool/tarantool#5845 > > Part of tarantool/tarantool#4473 > > --- > > test/PUC-Lua-5.1-tests/gc.lua | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/test/PUC-Lua-5.1-tests/gc.lua b/test/PUC-Lua-5.1-tests/gc.lua > > index 072bbe9..7f9880f 100644 > > --- a/test/PUC-Lua-5.1-tests/gc.lua > > +++ b/test/PUC-Lua-5.1-tests/gc.lua > > @@ -133,9 +133,12 @@ do > > local a = {} > > until gcinfo() > 1000 > > collectgarbage"restart" > > - repeat > > - local a = {} > > - until gcinfo() < 1000 > > + -- Tarantool has too many objects at start. `gcinfo()` result > > + -- is always greater than 1000. > > + -- LuaJIT: The test is disabled for Tarantool binary. > > + -- repeat > > + -- local a = {} > > + -- until gcinfo() < 1000 > > end > > > > lim = 15 > > -- > > 2.31.0 > > > -- Best regards, IM