From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9BECC6EC60; Wed, 31 Mar 2021 22:27:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9BECC6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617218841; bh=ALed5OaanG8Je52ag/fr1EUUJ/6kSkPcbjHpNRGvg+M=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GUyhomuFfB+ez9tbo+sjnkuzOE3jBZ4/sFUOmhihCPVnR6PRNztxACnwO9/1DtElk ZYtWly6H+HoX7AROAKlga3vmIMy5XRHGFta+l2g9QB7rCUTe0P/5Mty3iUo3JnyjNi bjWcGSrghMxs4Dhk8I1IA6yGiaCNjcoOfYsit0xc= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C0AB36BD01 for ; Wed, 31 Mar 2021 22:24:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C0AB36BD01 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRgSM-0003Wj-Uu; Wed, 31 Mar 2021 22:24:47 +0300 Date: Wed, 31 Mar 2021 22:24:37 +0300 To: Sergey Kaplun Message-ID: <20210331192437.GQ29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32941B7C4A78AC10F96A7797F60C25BD4B06182A05F5380850407E4199B7FA28457CD12B409EAA4BDF2C75A5AC4FE069FC673AF51382C39B3616 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FCFCB92DA8654BB0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF7387BAB2EBE114FDE934B3D56889279AA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE493B89ED3C7A6281781C6C49853BF2B2AEEC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5A789ED015A4075EBB2C9EA12B3353C6419CC9AECCA0678ADD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AEC7C2AC3C44791DC32DFF980DF295B300F8697F0B5CFCC5D75334D9CB10E90429DF51646E474A431D7E09C32AA3244C265F240F541CB26AF3F1D23469E1DCA78A6D4CC6FBFAC251927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20JnddR6yKRj3w== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638228353C719092855C476318C84399CDFA3A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 29/30] test: disable PUC Lua hanging GC test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. On 26.03.21, Sergey Kaplun wrote: > Tarantool has too many objects at start. `gcinfo()` result is always > greater than 1000 expected by the test. It leads to infinite loop in the > test. > > This patch disables GC test leading to hanging for Tarantool binary. Minor: I propose the following rewording: | This patch disables GC test leading to Tarantool binary hang. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/gc.lua | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/test/PUC-Lua-5.1-tests/gc.lua b/test/PUC-Lua-5.1-tests/gc.lua > index 072bbe9..7f9880f 100644 > --- a/test/PUC-Lua-5.1-tests/gc.lua > +++ b/test/PUC-Lua-5.1-tests/gc.lua > @@ -133,9 +133,12 @@ do > local a = {} > until gcinfo() > 1000 > collectgarbage"restart" > - repeat > - local a = {} > - until gcinfo() < 1000 > + -- Tarantool has too many objects at start. `gcinfo()` result I dare to guess that you're talking about *alive* objects here. Please mention this explicitly, if I'm right. > + -- is always greater than 1000. > + -- LuaJIT: The test is disabled for Tarantool binary. > + -- repeat > + -- local a = {} > + -- until gcinfo() < 1000 > end > > lim = 15 > -- > 2.31.0 > -- Best regards, IM