From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 596F86EC60; Wed, 31 Mar 2021 22:26:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 596F86EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617218812; bh=twJiwjgITHYjj5R5rQH/qL0jd4sYJPfdig7iwX1IZn0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bWP+la23sFkEEHO05vdrb/PjxIjMxmCbbwmHsaBJnYGPV7u3bLeJIG5LUcylhKL83 FDF/NcdXS7NeeMDCikRzhzj/7mlXi4ZoPcmthfi9HS4Keqy572Yzs/vJS0YPVgBKKJ uASgv3ePA4I52814qNBkhLbl/1C/eZSkarKMGrcM= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 461C470368 for ; Wed, 31 Mar 2021 22:24:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 461C470368 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRgSE-0003Ux-HC; Wed, 31 Mar 2021 22:24:38 +0300 Date: Wed, 31 Mar 2021 22:24:29 +0300 To: Sergey Kaplun Message-ID: <20210331192428.GP29703@tarantool.org> References: <2500605f6727f2759acf18804c31f652f3108324.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2500605f6727f2759acf18804c31f652f3108324.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040551404CDDB0ED566CC927B60200EDC7DF248EB674DF3AF186520D04F521B25FD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378A9F193E39E334918638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF87D09214884DA75C11BE51C709D19E52A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34C82C86BFC697D19117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B58781B77DE60D36C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5BBE48609F456C4E3E3538D794452C6766634DF165573EFD8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EC58E35A639A24714588E3D722F4208B870415DBA38550745FAA8B8F131D4878E4E3D6C4EB1857E41D7E09C32AA3244C529DE9661380E707BB3A479D22D56B7595A9E0DC41E9A4CF927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20L+EJSmOWy9lQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638229568389820609E286BCDDBE0CB24AF76A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 28/30] test: disable PUC Lua test checking -h option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. I see you added FIXME here, so we can uncomment the test, if we separate LuaJIT regular testing from Tarantool CI sometime... On 26.03.21, Sergey Kaplun wrote: > Tarantool returns zero status at exit with -h option, unlike Lua or > LuaJIT does. > > This patch disables test checking returning status, when binary Typo: s/disables test/disables the test/. Typo: s/checking returning status/checking the exit code/. > runs with -h option. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > -- > 2.31.0 > -- Best regards, IM