From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1E66A6EC60; Wed, 31 Mar 2021 22:26:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1E66A6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617218780; bh=pn76jeQV7kiFsAvPdMwZR41XO/EoKAtdgdMDMaMZo4U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hehDoFmUTyPHIBeEKfYnbhrAT04nibMZ5Cstq1uRYB8JsP9lyP2PPhijAABDiXZ1F E37Ugigjvw+50KaljmgmVOF/kaXKYtcJh4fczZ1/ZFtRMvYbIexD/q82bWPFBqj9vJ YFdgfaWUT31SsMiFeQM2odnW6xoQtqcQVgb7hiqs= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BE2776EC60 for ; Wed, 31 Mar 2021 22:24:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BE2776EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRgS3-0003Ri-Rx; Wed, 31 Mar 2021 22:24:28 +0300 Date: Wed, 31 Mar 2021 22:24:18 +0300 To: Sergey Kaplun Message-ID: <20210331192418.GO29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709498CFB6209D8582A182A05F5380850401CEFBFCF7F4A0E05FA3760520B3AD550E3F6EF9B7B876D6DC590CC285DE26CB0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063798FF8892961A0B3C8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF791D2B1AB75A7CA5C983944B16340CBDA471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F790063735872C767BF85DA227C277FBC8AE2E8B38189D631E94611675ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978312F0A634159382C960D9CEC0EA6A0B831 X-C1DE0DAB: 0D63561A33F958A53F13D605993B66CF1D1EF45D9D70B21113CD0D22F69C3D78D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34103A2CD2CFC42C67E35BCDF8380CAC77B68A50211B7963EC1F714FB1C41CBCCB8CE697068FAF11CD1D7E09C32AA3244C398F154BA5A8D8F9C18426973A3CA556F26BFA4C8A6946B8927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20IU4L6g31hHxw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822BB9083992DB3836759D928F27B859F69A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 27/30] test: disable PUC Lua test for checking arg layout X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the single nit. I see you added FIXME here, so we can uncomment the test, if we separate LuaJIT regular testing from Tarantool CI sometime... On 26.03.21, Sergey Kaplun wrote: > Unlike LuaJIT, Tarantool doesn't store the given CLI flags in `arg`, > so the table has the following layout: > * arg[-1] -- the binary name > * arg[0] -- the script name > * arg[N] -- the script argument for all N in [1, #arg] > > This patch disables test checking `arg` layout by negative indexes. Typo: s/disables test/disables the test/. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > -- > 2.31.0 > -- Best regards, IM