From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3DD2D6FC8C; Wed, 31 Mar 2021 22:24:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3DD2D6FC8C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617218691; bh=nT8872UM/YH8bTUk9CK/QxOaPF8hQpkIFGnCZA1JPO8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lVsm9ke6QLgeBxWMU5CGswLFwoHUpr4PjtaTnaGqP9on64s/vYcGow0llZ4zQWCj9 6Xdx7s7eoEArNjLaH/MTRtFGhmyQLYJdUhWZhsDoRLDNR8QBZHVQnGx+4ALq19qjw5 MiTV+W1O8JNJF5/LKrSUqRvSoCPH3lQXj3Ljq60U= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 42AB46FC8C for ; Wed, 31 Mar 2021 22:24:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 42AB46FC8C Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRgRj-0003Eh-Fq; Wed, 31 Mar 2021 22:24:07 +0300 Date: Wed, 31 Mar 2021 22:23:58 +0300 To: Sergey Kaplun Message-ID: <20210331192357.GL29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709C5527BBE40F25C64182A05F53808504009436A40904A3A50EBDC10EF55C2DDEDE6DA535DE38F5DC315CB7CF1E8E7C568 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E50EC9128971FD6EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374E88016F1B7D8D248638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFA414E68F1FB4744A5A763A8E85110507A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE78A0F7C24A37A3D769FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3329DC2EF12373DEA117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B58781B77DE60D36C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A50B68ECE8A71F78A4A919CFFA3E3A445D553577876A6598CCD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346B1FF97F6D0959A220FAC1ED5A546F6E52816D946DA1E8F9FF6162585BAD8B44B4262FC7EDD6070C1D7E09C32AA3244C968EDABCDD6299C7862FAD793A939646435BF7150578642F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20INnC6GV6uTsQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822F54290C19F82B134E689E02B3632C127A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 24/30] test: disable PUC Lua test for non-asci identifier X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. On 26.03.21, Sergey Kaplun wrote: > LuaJIT does not avoid to use non-alphanumeric symbols as identifiers, Typo: s/avoid to use/forbid using/. > unlike Lua does. > > This patch disables test that expects an error during parsing variable Typo: s/disables test/disables the test/. Typo: s/parsing variable/parsing the variable name/. > contains octal \255 as the first char in a variable name. Typo: s/contains/containing/. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/errors.lua | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > index af776a7..028224c 100644 > --- a/test/PUC-Lua-5.1-tests/errors.lua > +++ b/test/PUC-Lua-5.1-tests/errors.lua > @@ -202,7 +202,11 @@ checksyntax("[[a]]", "", "[[a]]", 1) > checksyntax("'aa'", "", "'aa'", 1) > > -- test 255 as first char in a chunk > -checksyntax("\255a = 1", "", "\255", 1) > +-- LuaJIT does not avoid to use non-alphanumeric symbols Typo: s/avoid to use/forbid using/. > +-- as identifiers, unlike Lua does. > +-- For more details see and . > +-- LuaJIT: Test is disabled for LuaJIT. > +-- checksyntax("\255a = 1", "", "\255", 1) > > doit('I = loadstring("a=9+"); a=3') > assert(a==3 and I == nil) > -- > 2.31.0 > -- Best regards, IM