From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B1A486EC60; Wed, 31 Mar 2021 22:23:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B1A486EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617218629; bh=1rZbmLuFevMUVhQTJdNE2LbXhFIzkByZWB+Y5/pWcPo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=fwj9YFNWJcVO6X0ZYhg4ci85/fpLa1uD+uVdSnzOUP+ZfvibXICWJhO2pQHOg7Rqd HZVyebTgJyHWoUSE3bSp6tG+pAT10/5hVQGwt5Sw6YBcsKVh01E1cZAlJ6EJqtF/9i DHlxxKz6Dglkz6TaG2EX/2lMbPl7xCVnrX/kqOUU= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C4C306EC60 for ; Wed, 31 Mar 2021 22:23:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C4C306EC60 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lRgRP-0002d9-L3; Wed, 31 Mar 2021 22:23:48 +0300 Date: Wed, 31 Mar 2021 22:23:38 +0300 To: Sergey Kaplun Message-ID: <20210331192338.GJ29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709C5527BBE40F25C64182A05F538085040A62503A5E3B0C3E35A09EE083E750CB5CB126E5B8DC20BBBD836DCABED46634F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CA8E915ACC910FBDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372A1456D053D20C618638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF2CA737BC822CFAB74CC076752DF88B70A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE493B89ED3C7A6281781C6C49853BF2B2AEEC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5D596DB0F70817579ADDC7A4A06CAE124519F7F117D3924A7D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3480665FBD8F49180C3C88FA043624AFD3F8B0AB54218AC032DD7F05E2112CBD95D888BC9998715FCB1D7E09C32AA3244C7A0D6D0107128D12B722FAAF318B24E56C24832127668422927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojetunDCtJ20IU4L6g21hHxw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382274437213266DE83FAC0D05D01A19A8D4A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 22/30] test: disable PUC Lua test for var names in error X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. On 26.03.21, Sergey Kaplun wrote: > LuaJIT includes variable name to the error report, when try to Minor: "error message" is more correct than "error report" here. > call non-function object without __call methamethod. Typo: s/methamethod/metamethod/. > Also, LuaJIT includes variable name to the error report, when try to Typo: s/includes variable name/includes the variable name/. > perform unacceptable arifmetic operation with the variable. > Lua 5.1 doesn't report variable name in these errors. > > Test ckecked that variable name aren't reported are disabled by Typo: s/Test checked/Tests checking/. Typo: s/name aren't reported/name isn't reported/. > this patch. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/errors.lua | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua > index e881211..cf24e40 100644 > --- a/test/PUC-Lua-5.1-tests/errors.lua > +++ b/test/PUC-Lua-5.1-tests/errors.lua > @@ -72,8 +72,13 @@ checkmessage("b=1; local aaa='a'; x=aaa+b", "local 'aaa'") > checkmessage("aaa={}; x=3/aaa", "global 'aaa'") > checkmessage("aaa='2'; b=nil;x=aaa*b", "global 'b'") > checkmessage("aaa={}; x=-aaa", "global 'aaa'") > -assert(not string.find(doit"aaa={}; x=(aaa or aaa)+(aaa and aaa)", "'aaa'")) > -assert(not string.find(doit"aaa={}; (aaa or aaa)()", "'aaa'")) > +-- LuaJIT: LuaJIT includes variable name to the error report. Minor: "error message" fits better than "error report". > +-- It looks like: > +-- "attempt to perform arithmetic on global 'aaa' (a table value)" > +-- Lua 5.1 doesn't report variable name here. Typo: s/report variable name/report the variable name/. > +-- Tests are disabled for LuaJIT. > +-- assert(not string.find(doit"aaa={}; x=(aaa or aaa)+(aaa and aaa)", "'aaa'")) > +-- assert(not string.find(doit"aaa={}; (aaa or aaa)()", "'aaa'")) > > checkmessage([[aaa=9 > repeat until 3==3 > -- > 2.31.0 > -- Best regards, IM