From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 894626EC60; Wed, 31 Mar 2021 13:49:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 894626EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617187770; bh=GsnblJWQu8LyD3foE67ci+ZuWUHrkZTKwCsp7wbs5xo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sn3oeNPO4n7d0gkFc0l84Rf4lfIgN927qNyBN0JYDgNuoRbmC21p7voGNH0P4AlLI DccDBZiybEVncGHlGBBZgE5IkgzhX7vrTEAWcvTvDWMa2eplk630Qti9QsqEwebmDt RC4dLQaCYwK/CkWgd9WXQoD0z/ezXKv5dEAK2yeQ= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B00FE6EC60 for ; Wed, 31 Mar 2021 13:49:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B00FE6EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRYPg-0004ne-IC; Wed, 31 Mar 2021 13:49:28 +0300 Date: Wed, 31 Mar 2021 13:49:19 +0300 To: Sergey Kaplun Message-ID: <20210331104919.GI29703@tarantool.org> References: <20210330221740.GF29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F53808504039BE9361E3D138E0790C30DD9403F5DCAA173D1260EB9964F731B62E32C40BF0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75210414551E8CD62EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E565730CA785C4918638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFB37A9315508FC4A56B7F98B6217AC8F2A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C353FA85A707D24CADCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F0FC70B58D375E76ACE5475246E174218B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5EF02F264733692201CC5F274F4939191458E0A2A45AB7719D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34197948450CB5442AD4752E51CEF12524F54D7264437CE9B05424303F540D004B5DD9EF0F1408AFDB1D7E09C32AA3244CBF5ED1EE4A2BF1564F791AC4B0B9F72E95A9E0DC41E9A4CF927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoZ+UuwUJEqcDw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382244B225D13B710B4F0C2751C4C977F61EA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 00/30] Adapt PUC-Rio Lua 5.1 test suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 31.03.21, Sergey Kaplun wrote: > Igor, > > Thanks for the review! > > On 31.03.21, Igor Munkin wrote: > > Sergey, > > > > Thanks for the series! I have two global comments for it: > > * 'LuaJIT:' tag usage looks inconsistent: let's move all of them to the > > beginning of the related comments. > > OK, I'll fix it with the new one series version, if you don't mind. I don't. > > > * Typo: s/LuaJIT's/LuaJIT/g. > > E.g. you never say "room's door" or "street's name". If you find the > > rule of possessives adjectives usage with inanimate subjects, please, > > share it with me. > > According to "The Oxford Dictionary of American Usage and Style" by > Bryan A. Garner, **POSSESIVES**, **H Inanimate things** section, > page 262: OK, I also spent a little time surfing the internet and found one[1] too. Hence this is the reason why your usage is so unnatural to me: as you mentioned you're writing with respect to the American dialect, but I was drilling Murphy a lot when I was younger, so "the old line" is stuck in my head forever. Therefore, it looks I can't stop you from using the language the way you want, but please *be consistent*. Good luck with using the "American Usage" for Lua 5.2 case :) > > | **Inanimate Things**. Possessives of nouns denoting inanimate objects > | are generally unobjectionable. Indeed, they allow writers to avoid > | awkward uses of `of` -- e.g.: `the book's title`, `the article's main > | point`, `the system's hub`, `the envelope's contents`, `the car's > | price tag`. > | > | The old line was that it's better to use an "`of` phrase rather than > | the `'s` to indicate possession when the possessor is an inanimate > | object. Write `foot of the bed`, not `the bed's foot`" (Robert C. > | Whitford & James R. Foster, Concise Dictionary of American and Usage, > | 1955). `Foot of the bed`, of course, is a SET PHRASE, the example is > | not a fair one. As a general principle, though, whenever it's not a > | violation of idiom, the possessive in `'s` is preferable | front entrance> - . > | > | But such possessives can be overdone for example, avoid using the > | possessive form of a year -- e.g.: "Mr. Rogers, 41, took the show by > | storm in 1993 winning 28 blue ribbons and the Show Sweepstakes with a > | total of 1,120 points (which really upped the ante: `1992's winner` > | [read `the 1992 winner`] scored only 387 points" (N. Y. Times). > > > * You use "PUC-Lua", "PUC Lua" and just "PUC" or "Lua" in commit > > subjects. Let's choose the single way referencing this Lua language > > implementation (and the corresponding test suite). > > Let's use "PUC" phrase everywhere, if you don't mind -- > "test:" prefix of commit message defines belonging to the test suite. I don't, but formally it's PUC-Rio. > > > > > -- > > Best regards, > > IM > > -- > Best regards, > Sergey Kaplun [1]: https://dictionary.cambridge.org/grammar/british-grammar/possession-john-s-car-a-friend-of-mine -- Best regards, IM