From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5E7BD6EC60; Wed, 31 Mar 2021 12:52:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5E7BD6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617184349; bh=V3WKqRpJilo/3h00dgGePFKWL7VDRc9Ogch+k20U5F4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OeH7O0b14xn1AUbJ3HawD2LpVprfkwc0G6m8FicGj1HLANdYJPUqNlrn8RXRcPKgJ oIlR7mV2lc0AapMnNZHAf3W6+4aJYUaJGQvRRk7R9xc3XaRCPNpiq8xNhab4DbAa61 a0A8kgrFgSGWT2356OpSDms7QCVHHFuOkhb4O3Os= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 57CD56EC60 for ; Wed, 31 Mar 2021 12:52:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 57CD56EC60 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lRXW6-0007sr-Af; Wed, 31 Mar 2021 12:52:02 +0300 Date: Wed, 31 Mar 2021 12:51:52 +0300 To: Sergey Kaplun Message-ID: <20210331095152.GH29703@tarantool.org> References: <9bf043d0714a15e51ca6e6f0778722da04e4c934.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9bf043d0714a15e51ca6e6f0778722da04e4c934.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F53808504054D272CEF57E06B5F6ED24D4BE087FD38A6C85DB61A51882196A7352E0D0D7AC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74D0D2DEF2EB846B0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063726CA83C7ABDB938E8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFE8496B488D4BFEA9A25E88D3E4C3EE7FA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3FD59DAE6580CC3C3117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352B32DCB92A8600C6C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783189C1F698F3DE33B2008EF5BE183B7CB3 X-C1DE0DAB: 0D63561A33F958A5F65CCD749E7E764594C410E8B04CECE29259D0EA9C63D563D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34087368DEEB028F17D575DB89B66060C5E9ECD51DF06D482541B3894984E799B26E1B546CC22349C21D7E09C32AA3244CF1967CD9D91C8D46806A3DA0C33866E91DD47778AE04E04D927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoYGSxLEWQdwIQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638226F78455C5FD6E27ECB8BE9EF6DE8B0C4A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 21/30] test: disable test for getfenv in closure tailcall X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the comments related to the wording. On 26.03.21, Sergey Kaplun wrote: > LuaJIT doesn't take into account tail calls for call-level counting, so Minor: This is a good example, when the passive voice makes the sense clearer. Consider the following: | Tail calls are not taken into account for call-level counting. Otherwise it seems like LuaJIT doesn't take into account *tail calls for call-level counting* (i.e. tail calls that are not used for call-level counting are taken into). Or simply try to use another preposition. > getfenv() behaviour is different from Lua 5.1 in tail calls. Minor: You use both "tailcall" and "tail call" within this commit. Please choose one and use it everywhere. > > This patch disables test for the return result of tail call getfenv(). Typo: s/tail call getfenv()/getfenv() tail call/. > Default value (equals 1) of getfenv() function's argument (function Typo: s/equals 1/equals to 1/. > level) is invalid for this tail call -- LuaJIT can't provide necessary > debug information for the frame. Minor: I would explicitly mention, that there is no a separate frame for tail call. LuaJIT simply uses the existing one created for the caller. > > Relates to tarantool/tarantool#5713 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/closure.lua | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > -- > 2.31.0 > -- Best regards, IM