From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7A9D96EC60; Wed, 31 Mar 2021 01:21:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7A9D96EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142868; bh=XbTe84N+EbHBvKLAyApfNFawkI2Dbdw02rC57cdJD/k=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=R4bVEnoWyheBoI/KgShA66e2cnTnz9p6XSiAmHxh0Kh4uFRW0uzHCbzXyn/3giD3m VqKaPJSd1y4iSMwPgtPBbcv4tGTtpCj3QZx9+u+wVAOdY1jOU3qBg1k3i7/KIL+b4+ 3RCQbElt/acBhcVoFNpRY9YCcvEyn5tCoR8eLM0c= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BBE206BD01 for ; Wed, 31 Mar 2021 01:17:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BBE206BD01 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRMgH-0005ah-RU; Wed, 31 Mar 2021 01:17:50 +0300 Date: Wed, 31 Mar 2021 01:17:40 +0300 To: Sergey Kaplun Message-ID: <20210330221740.GF29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F5380850409B51A72746A572A524B215C5CEB6F4FAD63654548577BD587166C0EA46F0FF2A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637889C00975665ABF68638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFFBA7735A33B74A1FFA348BB002E1E4F1A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F3CCD8A865B74A75C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783119062ECCC221CF453AC67FABDE5538EC X-C1DE0DAB: 0D63561A33F958A594CBBC3353B890ECA05108A88F847BDE1AF138884ED2F102D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F507C2EA0814E450BC3936281738ACAB0F1F458E0F79F462D49F50E84E645D2D81591E93D8027D0B1D7E09C32AA3244CCCB2256CCB00CD131D741C9F57144015408A6A02710B7304927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoYqN65CBZQHxQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638224110F383D364B37FF7E9A28632B79793A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 00/30] Adapt PUC-Rio Lua 5.1 test suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the series! I have two global comments for it: * 'LuaJIT:' tag usage looks inconsistent: let's move all of them to the beginning of the related comments. * Typo: s/LuaJIT's/LuaJIT/g. E.g. you never say "room's door" or "street's name". If you find the rule of possessives adjectives usage with inanimate subjects, please, share it with me. * You use "PUC-Lua", "PUC Lua" and just "PUC" or "Lua" in commit subjects. Let's choose the single way referencing this Lua language implementation (and the corresponding test suite). -- Best regards, IM