From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C24A26FC8C; Wed, 31 Mar 2021 01:20:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C24A26FC8C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142838; bh=S5nP7fEBi7q5aRQu0cLVRwyUD4/FzOxZ372ptj/1/xY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=J+EZlz5ALeRz3fxWKLyjCToHaE//p0RftW8xvFY9CLtqhrWIei9+okPCwGB0CRdM1 ODYYo9YeB162U8naJkk3q9Z8sRAeHvjZkMGahC1F4cfYAH77AMA8EvtlGXsqrRfu+i /E8yBZup+h8ivWccNl9Gv7phtVkqKcbembAD4tPg= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7CCA76C185 for ; Wed, 31 Mar 2021 01:17:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7CCA76C185 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRMg1-0005XZ-Lg; Wed, 31 Mar 2021 01:17:34 +0300 Date: Wed, 31 Mar 2021 01:17:24 +0300 To: Sergey Kaplun Message-ID: <20210330221724.GE29703@tarantool.org> References: <946be811cd2557fb65459c0de499cdc62229fdd6.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <946be811cd2557fb65459c0de499cdc62229fdd6.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709498CFB6209D8582A182A05F53808504085A1F02F3AD229D2B37AED6D16850CB9F9C706CEEB95A4EAF355C79A1336E493 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637129C704593A46970EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664EF7DA896057A139BEC9FFDE98B4388F6EE12B5935DE13AF4389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B65FF0BFC5AEE34BE6CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F890A246B268E114E262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5E0C834283CD312D75C1D3DCF7C7004812C4C6B5CEFFA3ED3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F1757F8DFBC5C33FD0B14E400A83CA58E991F9F496AAE7D67DC2D54596BE3BE3A7C833547C95F8D1D7E09C32AA3244CC312E9158A29A477C781A673142332877C0C08F7987826B9927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGobtDfWcjnmCyQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822748914DCCE6E12CAF7EB3AB85C175A7AA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 19/30] test: remove assert for string.gfind check X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the single nit. On 26.03.21, Sergey Kaplun wrote: > In Lua 5.1 function `string.gfind()` was renamed to `string.gmatch()`. > You can use it if Lua 5.1 is built with compile-time option > `-DLUA_COMPAT_GFIND`. > This built-in is removed from LuaJIT. Please mention the patch[1] where this builtin is removed. > > This patch removes test checking that `string.gfind()` and > `string.gmatch() is the same function. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/pm.lua | 1 - > 1 file changed, 1 deletion(-) > > -- > 2.31.0 > [1]: https://github.com/tarantool/luajit/commit/de5568e -- Best regards, IM