From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DFCA66EC60; Wed, 31 Mar 2021 01:19:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DFCA66EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142775; bh=872BmRI1DG9LB/3gvixuI4edPa5W4mhT+y8uezS5TGI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xmGQUu/rBZ9N0MOh77AZYgSvQ2OFJi4L1D2GW6cKZvkv9PaMmehcxARdlQehmHvq2 R1SLB+/w50oksgwW++e64n72zmYMwWB/nRTdUQVyy9MrJa8riTc31wAX6bXwQ9nHma 9GIMQ/FGH+Uwv7GWmepvzrvv+hFuDYThUOGWYPog= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8D9206BD07 for ; Wed, 31 Mar 2021 01:17:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8D9206BD07 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRMfa-0005L2-NP; Wed, 31 Mar 2021 01:17:07 +0300 Date: Wed, 31 Mar 2021 01:16:57 +0300 To: Sergey Kaplun Message-ID: <20210330221657.GC29703@tarantool.org> References: <2ffe160c0e47930914ff03996df38af1d9625767.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2ffe160c0e47930914ff03996df38af1d9625767.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F538085040AD0E15EC9C2932000BD3A2C6673F6B19EDE840D16A0B108A706935AE7E20DFA4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD2F2D6F6013FF7FC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7F2919D563845004AEA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664EF7DA896057A139BD9046C4AEBF8220E5FB373B9555E21EE389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C05A64D9A1E9CA65708941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B68BFD6B1B042489ACCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F3D16C27877C51C136D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5671B86F5D7F8BA805A07F020CA1257D0172785A1ED308D33D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3468964757141B82E09C4014383B9CDACBD635D22FCC3161157DD66590E8CFE43D5B15B17C6377C9ED1D7E09C32AA3244C9EF91C4DCEBD2C891F7FAFEB74996EBD51E887DA02A9F7BF927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGobZ2wAbDy2BwQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822032D4E62D2396E073275E93ECE847F96A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 18/30] test: replace math.mod to math.fmod for Lua tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. There is a typo in commit subject: s/replace math.mod to math.fmod/replace math.mod with math.fmod/. On 26.03.21, Sergey Kaplun wrote: > In Lua 5.1 math.mod() is renamed to math.fmod() if build Lua 5.1 without Typo: s/if build Lua 5.1/if Lua 5.1 is built/ or s/if build Lua 5.1/if one build Lua 5.1/. > flag `-DLUA_COMPAT_MOD`. Typo: s/flag `-DLUA_COMPAT_MOD`/`-DLUA_COMPAT_MOD` flag/. > LuaJIT has math.fmod() instead old-style math.mod() built-in. Typo: s/instead old-style/instead of old-style/. You can also mention the commit[1] where this is done. > > This patch replaces usage of math.mod with new-style math.fmod > in the following files: > * closure.lua > * constructs.lua > * math.lua > * nextvar.lua > > Closes tarantool/tarantool#5711 As we discussed before: s/Closes/Resolves/. > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/closure.lua | 3 ++- > test/PUC-Lua-5.1-tests/constructs.lua | 6 ++++-- > test/PUC-Lua-5.1-tests/math.lua | 3 ++- > test/PUC-Lua-5.1-tests/nextvar.lua | 3 ++- > 4 files changed, 10 insertions(+), 5 deletions(-) Typo: s/instead old-style/instead of old-style/g in all chunks. > > -- > 2.31.0 > [1]: https://github.com/tarantool/luajit/commit/de5568e -- Best regards, IM