From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B543D6EC60; Wed, 31 Mar 2021 01:19:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B543D6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142745; bh=8wruiJq2jeyklQW5E4fB3dFqlj/v4+Cfm/Nfj4R2F0o=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ppCl0GyY69LSsRPq+dHB3cR9uQtw2zzDSDSxNiZA2svl1Wf9zuvR3fisLd3BBAK/N VSjXSQKoezT8T5ENArzJr9lLAy+F1f52I1J3nc0BpWk4DzfbiHX13RLzGO5pi6fp4S 9zeSqMGT8ciVmBasoDdj/YKsNcUxICgsapJm+UIY= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D40486FFA3 for ; Wed, 31 Mar 2021 01:16:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D40486FFA3 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lRMfL-000366-0J; Wed, 31 Mar 2021 01:16:51 +0300 Date: Wed, 31 Mar 2021 01:16:41 +0300 To: Sergey Kaplun Message-ID: <20210330221641.GB29703@tarantool.org> References: <86ead4f35be1f65e9e4c0e46715d42a05851ba6d.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <86ead4f35be1f65e9e4c0e46715d42a05851ba6d.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040503A51B5D5874EABEF97E4CE0A882C4FC474E12449C99CE9ACB15251462E6518 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371005780D56A98C20EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664EF7DA896057A139BAD452BEBEF7C66FE496B7E27971AD7BE389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B66EA1BA7CA28B4A74CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F890A246B268E114E262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C9783119062ECCC221CF45EE3E100BA2433E01 X-C1DE0DAB: 0D63561A33F958A56B1A3FE2D15F497832C86BDEBC1E835CD4D7FAEE76669D6CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3475AE8838CC1BF58E1C200DED6BB6FE9DE118196B9B90344277B79F8C0D336E5C05E80746063C17451D7E09C32AA3244C10B78ECB9964AC6141964295658DC25EB4DF56057A86259F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoYFq/tKd7aLyg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822E5491361AAC9A3215140BACE5FB16FF7A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 17/30] test: disable locale-depended tests for Lua suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. On 26.03.21, Sergey Kaplun wrote: > LuaJIT doesn't compare strings by `strcoll()`, like Lua 5.1 does. > So locale-depended tests in are disabled. Side note: unfortunately, this is not mentioned anywhere except the sources... Classic. > > Also, LuaJIT doesn't use `strtod()` depended on the locale for parsing, Typo: s/depended/dependent/. > unlike Lua does. See for more info. > Locale-depended tests in are disabled. Minor: Please, refer the docs[1] or the patch[2] changing the behaviour in the commit message. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/literals.lua | 5 +++++ > test/PUC-Lua-5.1-tests/strings.lua | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/test/PUC-Lua-5.1-tests/literals.lua b/test/PUC-Lua-5.1-tests/literals.lua > index 01d84d5..1b4f664 100644 > --- a/test/PUC-Lua-5.1-tests/literals.lua > +++ b/test/PUC-Lua-5.1-tests/literals.lua > @@ -158,6 +158,10 @@ end > > > -- testing decimal point locale > +-- LuaJIT: LuaJIT doesn't use `strtod()` depended on the locale, Typo: s/depended/dependent/. > +-- unlike Lua does. See for more info. > +-- Tests are disabled for LuaJIT. > +--[[ > if os.setlocale("pt_BR") or os.setlocale("ptb") then > assert(tonumber("3,4") == 3.4 and tonumber"3.4" == nil) > assert(assert(loadstring("return 3.4"))() == 3.4) > -- > 2.31.0 > [1]: http://luajit.org/extensions.html#tonumber [2]: https://github.com/tarantool/luajit/commit/4c882fe -- Best regards, IM