From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E7F136EC60; Wed, 31 Mar 2021 01:18:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E7F136EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142684; bh=rjZSbUHif5K87BwJBmxXjFuHnstSoxDoigHUdTClG48=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AXkO/TkDnsGvzs5jks1Jp1j5cLpdTS6n4Dvv2jxtK4ruSbl47ke7WynnCVvHSbgjy zkwmKn3EF9hcS4G95n1WqldaxlBRGyHzl2Te/TvM3AP79dbWl+EU66OFpW+dkkLWyr MT59I08j3VbtKlkh0ibOrSfUdMCXi3PiDDi7rHUo= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BFBA66EC60 for ; Wed, 31 Mar 2021 01:16:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BFBA66EC60 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lRMeu-00030q-Rb; Wed, 31 Mar 2021 01:16:25 +0300 Date: Wed, 31 Mar 2021 01:16:15 +0300 To: Sergey Kaplun Message-ID: <20210330221615.GZ29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F53808504052905F72AD7A3DDCEF9DBDCFB22697DC9D105E799B136016C33B6F82A77BB66C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A8325FA649D0A450EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373D58C44ED3182E498638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF81392AACA1EC0E9E242A138BF587DBC1A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE73AFA331E307B52169FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C345F93BA578C2B99F117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F1C9CF18C8EB2269C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5FB6F7185B1A8D5D5FAB77329B6587E3FA32048312F3CC41BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3403182E70AE6895E0EAD2812EC1D3AF575E73D49CA1A475B93436C96D72FE2FDE15874C73286C09931D7E09C32AA3244C76896CA8D1C993780A3E9FEB81E4D6395A1673A01BA68E40927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoaVfWN92mJlrA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382226A9570D47D5538DA1A7E5C191BFA837A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 15/30] test: disable PUC-Lua test for per-coroutine hooks X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the one nit: I would explicitly mention that hook is set *but* for the whole VM instead of the given coroutine. Hence hooks work, but assertions are disabled. -- Best regards, IM