From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5DBA86C7D3; Wed, 31 Mar 2021 01:17:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5DBA86C7D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142625; bh=lYYx61z9KAbbe9JUZ/fHpfOuEUEGqiTr4qvxMcFR9k0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r0NsN3VrGXmGdzv201HrbEVnreuEWEvI54fN+YGnwhhN47MJAKGvGqi3aKXEwcL/D RTG9TJ8BzGZz8akntYWz+UKcQElUxzwNYLJ3vD9HWuzoAst/iYFWTpc6iMjAtpLaIg 01nnIepF6Oys1I8CaRogbqRu/y5bHg8ftpkF3I9Q= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8F54D6BD02 for ; Wed, 31 Mar 2021 01:15:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8F54D6BD02 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRMeF-0004sN-Ja; Wed, 31 Mar 2021 01:15:44 +0300 Date: Wed, 31 Mar 2021 01:15:34 +0300 To: Sergey Kaplun Message-ID: <20210330221534.GX29703@tarantool.org> References: <43c7a2668c9d3935e792363a7a6536a4801e28a8.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <43c7a2668c9d3935e792363a7a6536a4801e28a8.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709498CFB6209D8582A182A05F53808504016879D26A806D8669D5816A8280BEF1C604807585F06501E1E8B3D373BBD2754 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F6EE1C40B2E8BE15EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CE17C7754E00FC028638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF0749B6D13C2A727C64E95187E0EC71D3A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE493D58E677C372A3F47B25CBF701D1BE873C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831CB1BC92B6A8DCFA00BD5C9FA4661C8D9 X-C1DE0DAB: 0D63561A33F958A50818E26B123F3928DEA39CB837D1DB6BF849D7E181E392FED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345C064E16D8ABF3359B87ABDDED34F692EA0AAC239AA4E020611F7821E0C98BFB081F5A787EB34ED41D7E09C32AA3244CCC06E6F95F8BCADD2AF043C3340BD1DFE3D93501275E802F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoZ8AmWSvET87g== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822B479CFDB5A5D1AB3B74149C523DEFC9DA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 13/30] test: disable PUC Lua test for tail call info X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. On 26.03.21, Sergey Kaplun wrote: > LuaJIT does not provide information about tail calls in debug.getinfo(), > unlike Lua does. This missed feature is described in > https://luajit.org/status.html. > > This patch disables tests for tail call checks and getfenv() checks, > because tail calls do not provide an additional level for LuaJIT It's not "level", but "call frame", AFAIU. > and level number given to getfenv() should be changed. > > Relates to tarantool/tarantool#5702 > Relates to tarantool/tarantool#5703 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/db.lua | 30 ++++++++++++++++++++++-------- > 1 file changed, 22 insertions(+), 8 deletions(-) > > diff --git a/test/PUC-Lua-5.1-tests/db.lua b/test/PUC-Lua-5.1-tests/db.lua > index c1a635a..b363abc 100644 > --- a/test/PUC-Lua-5.1-tests/db.lua > +++ b/test/PUC-Lua-5.1-tests/db.lua > @@ -400,19 +400,29 @@ function g1(x) g(x) end > > local function h (x) local f=g1; return f(x) end > > -h(true) > +-- LuaJIT does not provide information about tail calls, > +-- unlike Lua does. See also https://luajit.org/status.html. > +-- getfenv() behaviour is also different here, Typo: looks like line underfull (in LaTeX terms, heh). > +-- because tail calls do not provide additional level for LuaJIT > +-- and level number should be changed. > +-- FIXME: Test is disabled for LuaJIT. > +-- See also https://github.com/tarantool/tarantool/issues/5702. > +-- h(true) > -for _, k in ipairs(res) do assert(k == table.remove(b, 1)) end > - Typo: excess whitespace change. > +-- Behavior is different for LuaJIT. See the comment above. > +-- FIXME: Test is disabled for LuaJIT. > +-- for _, k in ipairs(res) do assert(k == table.remove(b, 1)) end > -- > 2.31.0 > -- Best regards, IM