From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DB0C86FFA3; Wed, 31 Mar 2021 01:16:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DB0C86FFA3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142595; bh=E0h2W0isvBluWZRvbXcxArLbSMmQYLftv2ALVyv4bKA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=A+qKQ2KrlbZg02Axd177WRJScv+3h2Uf6eQa++Ux6QV2VjqIqfJ5as2QCF8GHXAye GJIJVPw3y6obA4lhmGgK9agbzGZbGYYHByG3pDhECymAR1EZdKq/MB/2lv8rDnvhjn qk2SVXpN6XHAVUkCYcRB7W+c1LTfUeiePEuwiVcM= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DF8276FFA3 for ; Wed, 31 Mar 2021 01:15:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DF8276FFA3 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lRMe2-0002gJ-Vp; Wed, 31 Mar 2021 01:15:31 +0300 Date: Wed, 31 Mar 2021 01:15:21 +0300 To: Sergey Kaplun Message-ID: <20210330221521.GW29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32941B7C4A78AC10F96A7797F60C25BD4B06182A05F5380850402E567088C28FB1062AFD796037A7BD7E4F40BF86CEE0891B79A9F865B443CF31 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376F978168E59B07A5EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664EF7DA896057A139B375D03A0C175142A8BB800AE5F6DA5CC389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B625DC386152A6764ACC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F3D16C27877C51C136D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831CB1BC92B6A8DCFA02240D5316989BD39 X-C1DE0DAB: 0D63561A33F958A5C21F7141632C3F7C48F19CDA49105D743ECCC6B1C8EC9D77D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345C064E16D8ABF335A3F54F657F000F347DE27B9BF723A8EE89C48A18009D5310729F4437A59686C41D7E09C32AA3244C657246B6E80956549822AB11DE999F698894E9C85370243E927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoaasXgyPXusBw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382268681469FF6E349DCF0022CC7A7FC3F3A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 12/30] test: adapt PUC Lua test with count hooks X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the single nit below. On 26.03.21, Sergey Kaplun wrote: > LuaJIT does not check hooks at traces without defined > -DLUAJIT_ENABLE_CHECKHOOK. For more information see > or commit 6bce6b118eeb2bb7f36157de158e5cccf0ea68e5 (Add compile-time > option LUAJIT_ENABLE_CHECKHOOK. Disabled by default.). > > This patch adapts these tests for LuaJIT by disabling JIT while testing > count hooks. > > Closes tarantool/tarantool#5701 As we discussed before: s/Closes/Resolves/. > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > -- > 2.31.0 > -- Best regards, IM