From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6619D6EC60; Wed, 31 Mar 2021 01:16:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6619D6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142566; bh=adVPnbFXB/yhwOFL+Q9divh0vaPEXr8vAvofdTIimrc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Aa6hBg/YYIoGI2hY59KDeNfBlr/m6WV0GgdVQsRZtVVo5khWTpjNmTKq5AMGuuhIu yveIjNwmpZng4R4ExAgjbH4yPTKbIX+gO0liagWe1VrryMLHe/fJh28ukV0vJiIWXr diLIHnkewov+lx6ad03ZfLBvv8J5AM/OVGCKUpJk= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E73416FC8C for ; Wed, 31 Mar 2021 01:15:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E73416FC8C Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lRMdo-0002dM-3S; Wed, 31 Mar 2021 01:15:16 +0300 Date: Wed, 31 Mar 2021 01:15:06 +0300 To: Sergey Kaplun Message-ID: <20210330221506.GV29703@tarantool.org> References: <0bf0dc418d1095fc5c8d3901469662c853fb93de.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0bf0dc418d1095fc5c8d3901469662c853fb93de.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32941B7C4A78AC10F96A7797F60C25BD4B06182A05F5380850402250EC980E5634A997BAE663E7D056DC091348A67D734AA94B0543FBEB3BB8A5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375F0BD5CF353A411D8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFF38DD9B744DEF437D5BB6DAC4CA1FF0DA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE493D58E677C372A3F47430FDFEF8887E0B2C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831CB1BC92B6A8DCFA0132AFB0E068B8FEB X-C1DE0DAB: 0D63561A33F958A50539613A0D6C3494E42BF21D2DA592A3266E4914CD4B1A27D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3455049D7B43D89D64FF9BA03755AE9F6DAF3000C866E59B1481CD71CA84E5C6FF43D10C71942314D11D7E09C32AA3244C4D37FD616030F9B8E79210C8C9870A78FE8DA44ABE2443F7927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoY0uXowruoI7g== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382265FDE46DDDE324293B21042C4BDEADBAA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 11/30] test: adapt getlocal PUC test for vararg func X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! I can't understand why this patch is separated from the previous one. Could you provide a rationale for this, please? BTW as we discussed before: s/Closes/Resolves/, considering your changes on the branch. Also consider the comments below. On 26.03.21, Sergey Kaplun wrote: > Lua 5.1 interprets `...` in the vararg functions like an additional Typo: s/like/as/. > first argument unlike LuaJIT does. So, `a:f()` function will not set > corresponding table `arg`, as test expects. Typo: s/set corresponding table `arg`/set the corresponding `arg` table/. > > Implicit `arg` parameter for old-style vararg functions was finally > removed in Lua 5.2. The test is adapted from PUC-Rio Lua 5.2 test suite > by removing additional check for amountt of arguments via `arg.n`. Typo: s/amountt/amount/. > Lua 5.2 test suite is taken from > https://www.lua.org/tests/lua-5.2.0-tests.tar.gz. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/db.lua | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/test/PUC-Lua-5.1-tests/db.lua b/test/PUC-Lua-5.1-tests/db.lua > index e5d8885..6985c29 100644 > --- a/test/PUC-Lua-5.1-tests/db.lua > +++ b/test/PUC-Lua-5.1-tests/db.lua > @@ -300,7 +300,16 @@ debug.sethook(function (e) > +-- LuaJIT: Lua 5.1 interprets `...` in the vararg functions like Typo: s/like/as/. > +-- an additional first argument unlike LuaJIT does. > +-- So, `a:f()` function will not set corresponding table `arg`, Typo: s/set corresponding table `arg`/set the corresponding `arg` table/. > +-- as test expects. > -- > 2.31.0 > -- Best regards, IM