From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1B86F6EC60; Wed, 31 Mar 2021 01:15:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1B86F6EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142535; bh=F0Ph++qJ9iord852G59yhxZycafsfdgEw6CPWeEg0NA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=y18ZjI7r1o8nY4HUxszBbQ1jRJMpyUb65WTjwFpKyeqoZ0p7EYxXpTbUgMyw23x+a rCb4o9WoYC6BMASMICupp24CtvsKYC6ogJg4U0+uG9BfscLf16Bzj/tDlnJ8POqCFu LQUfd1X89PekUKAYpMlNf46zAnwIdhAzt40rA/dE= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6C1A86EC60 for ; Wed, 31 Mar 2021 01:14:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6C1A86EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lRMdM-0004X4-FR; Wed, 31 Mar 2021 01:14:48 +0300 Date: Wed, 31 Mar 2021 01:14:39 +0300 To: Sergey Kaplun Message-ID: <20210330221439.GU29703@tarantool.org> References: <2a4f7f1c49f5c9c0ffd1a512d809588f7a7694db.1616743343.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2a4f7f1c49f5c9c0ffd1a512d809588f7a7694db.1616743343.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4ABD7C98AF5DBFD37182A05F538085040F09E7E1B1731165A443500918109AA599C5FDBEBDBD1C47FA8825645367DCF84 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE782A779A89F7D69B2C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664EF7DA896057A139B808DFC5DA342F9676C1752ACBC20006A389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0DCF4F0DC832992758941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B625DC386152A6764ACC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5CCE5475246E174218B5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978319F19FB8AEBFC852E63EC326E2DBBB914 X-C1DE0DAB: 0D63561A33F958A5A3C5BA1287C299709B3CB4054E4F990D5CFF1638408E1373D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E229BE567979C94094B56FBE9E38BBDB0FD9AA31522A163C79093C4DDEEA0D0344350BE847424B481D7E09C32AA3244C16E50716ADB87F88A91CFE9F28B9D1C7A95CA90A1D8AC565927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoYbmc8e34QHJA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638228CA6617F9E24E06CB114EE29A67483DDA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 10/30] test: adapt test for debug.setlocal in Lua suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, considering your changes on the branch. Also consider the comments below. On 26.03.21, Sergey Kaplun wrote: > LuaJIT: Lua 5.1 interprets `...` in the vararg functions like Looks like you just copied the comment below. There is no need for 'LuaJIT:' here. > an additional first argument unlike LuaJIT does. > This behaviour is extension is from Lua 5.2. Typo: s/is extension is/is extension/. > > This patch adapted test considering LuaJIT's and Lua 5.2 behaviour. Side note: Here it is -- you wrote LuaJIT's but Lua 5.2 (neither Lua's 5.2 nor Lua 5.2's). How come? > The test is adapted like it done in Lua 5.2 test suite taken from > https://www.lua.org/tests/lua-5.2.0-tests.tar.gz. > > Closes tarantool/tarantool#5694 As we discussed before: s/Closes/Resolves/. > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > -- > 2.31.0 > -- Best regards, IM