From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D98BF6FFA3; Wed, 31 Mar 2021 01:15:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D98BF6FFA3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617142504; bh=kZcP9dz2psZzFgI5gXC6CuhIbe9yNQ+mvJtuONnk3OU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=T/Sus+8hUp2T3sMeBrL7a5TRDG6GcKJuO4TZB/4K2NZK8V9yfauwkHtXjGk8TGp8g 7E4QSYyEj8dpWJA/ONKMfRi6pE60od1jlC/KhfTRQf9gwQez3uuoeUGjRh1EWWSpdT u0YVCmEK5yNgUEpT6H0eT30Zd5w5adcapfqhjzsk= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8A9086FFA3 for ; Wed, 31 Mar 2021 01:14:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8A9086FFA3 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lRMd5-0002KN-PR; Wed, 31 Mar 2021 01:14:32 +0300 Date: Wed, 31 Mar 2021 01:14:22 +0300 To: Sergey Kaplun Message-ID: <20210330221422.GT29703@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F538085040A679865F1432265F48FA7CF57833908E9C5FDBEBDBD1C47F9418CC399E841C51 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE741DC22BF90A736D8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374E88016F1B7D8D248638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF606A148FE63A34B15B7C65FA87B38BECA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE493D58E677C372A3F4780CB4917E5AABA03C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978319F19FB8AEBFC852E8FF110C78C8E6CED X-C1DE0DAB: 0D63561A33F958A562F01A5F303C02CED251097164C9F8C071641F20884CF06ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3483E1FCD56FEA62E6FDF2102C45BAA3905DF7D2905AFEA8962DDB2B1A14114DD8380A1D70A1A512201D7E09C32AA3244CE46CECF6FD64E7628F05687B39F82A3EA95CA90A1D8AC565927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGoZ010ErYpTDNg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822C31CA26C4686F303CF3E8CE948D7073AA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 08/30] test: disable JIT for GC step counting tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! LGTM, except the nits below. I propose the following rewording for commit subject: | test: disable JIT for the tests counting GC steps On 26.03.21, Sergey Kaplun wrote: > JIT compilation can unpredictable allocate or reference objects (or Typo: s/unpredictable/unpredictably/. > traces itself). So, the amount of GC steps can vary from run to run. > > This patch disables JIT machinery, if it is enabled, for stable GC > results. > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/gc.lua | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/test/PUC-Lua-5.1-tests/gc.lua b/test/PUC-Lua-5.1-tests/gc.lua > index 86a9f75..072bbe9 100644 > --- a/test/PUC-Lua-5.1-tests/gc.lua > +++ b/test/PUC-Lua-5.1-tests/gc.lua > @@ -108,11 +108,21 @@ local function dosteps (siz) > return i > end > > +-- LuaJIT: JIT compilation can unpredictable allocate or reference Typo: s/unpredictable/unpredictably/. > +-- objects (or traces itself). Disable it if necessary for > +-- this chunk for stable GC results. > -- > 2.31.0 > -- Best regards, IM