From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BBEAF6EC5B; Tue, 30 Mar 2021 00:58:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BBEAF6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617055137; bh=3perMz74H7YU1JBZRP42YZWojPx4vbtjwjmEM1IDADk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=o8m0buL64boXDtmn8X8vt9yfTdLZlSkA6pY1+hKg30NHvcSSoMqMIDhNYlAT1+Unk 15hVoJOro26rNmhv5HmFOT0bimeOgq2sYfD/ffpdQBme8zIlNwYNI3O5ZqEaPF4J+s 1+zCKe1+9G8i/6K2tFpoTg7PhBye5S5lfCuroGgY= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7106B6EC5B for ; Tue, 30 Mar 2021 00:58:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7106B6EC5B Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lQzuR-00055b-KG; Tue, 30 Mar 2021 00:58:55 +0300 Date: Tue, 30 Mar 2021 00:58:46 +0300 To: Sergey Kaplun Message-ID: <20210329215846.GQ29703@tarantool.org> References: <20210326164855.30242-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210326164855.30242-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E329498ADEA61F680B110809A4DE3E6FC56EA182A05F538085040E520268715FC5AA1441708C6CE0AE8BC9E195F44CE007AD50393026B8AD9BE55 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD2F2D6F6013FF7FC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7EC0B1A4921CAE631EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC76648736E98A3ECD1341D12F13E58819D6CCC6338611AABB9ED4389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92A417C69337E82CC2CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F890A246B268E114E6D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A52C0B0CBD1AF05B8B06CD588B4F0C72688CE2AEAC52FE1E51D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F1757F8DFBC5C33A6747994661C0E4F1BC5C7C4846FE5822A4DB0B5ED38DE7D6CE2981F7BDE6B631D7E09C32AA3244CDCDDCD0BADDA511E94F470953D8EF2F630363D8B7DA7DD44927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rT9KrbB5RWl5Q== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822880C62A74DD6C6819169A3F6ECCF7021A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the series into tarantool branch in tarantool/luajit and bumped a new version in master. On 26.03.21, Sergey Kaplun wrote: > Profiler parser output looks like the following: > | ALLOCATIONS > | @true_memleak.lua:6, line 9: 3 144 0 > | @true_memleak.lua:6, line 8: 2 41 0 > > Line of function definition is confusing for users and looks redundant. > Also, these "magic numbers" may shock users. > > This patch removes lines of function definitions from the output. > Info about the line function definition is saved inside symbol info > table by field `defined` (it can be used later for a user's custom > parser). Moreover, explanatory words and signs are added to numbers > for more verbose output. > > After the patch, profiler parser output looks like the following: > | ALLOCATIONS > | @true_memleak.lua:9: 3 events +144 bytes -0 bytes > | @true_memleak.lua:8: 2 events +41 bytes -0 bytes > > Resolves tarantool/tarantool#5811 > Part of tarantool/tarantool#5657 > --- > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5811-user-friendly-memprof > Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5811-user-friendly-memprof > Issues: > * https://github.com/tarantool/tarantool/issues/5811 > * https://github.com/tarantool/tarantool/issues/5657 > > test/tarantool-tests/misclib-memprof-lapi.test.lua | 4 +++- > tools/memprof/humanize.lua | 2 +- > tools/utils/symtab.lua | 5 +++-- > 3 files changed, 7 insertions(+), 4 deletions(-) > > -- > 2.31.0 > -- Best regards, IM