From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 915756EC60; Mon, 29 Mar 2021 23:48:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 915756EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617050939; bh=o4YE/87la3x6ka4w1MZm+dWZrCI3hKMOyW2ZD/HbrB0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RRUYCpdXDPHLdRWd+ViZLz/e3rw+1NGy1wLMlZO/2mYy+jVhe14Hw0v+qpVbmdkWq ViTx/pRR0q/Zvn3y+JiJ5xFqF0VUePcj2I+0uGNEQFdhiN98ghAvIHds/VlUOyPzyc nprXqkaBpCGlqEsCrOdGkWvDn20WxdJMaaGumrMA= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1B1596EC60 for ; Mon, 29 Mar 2021 23:48:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1B1596EC60 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lQyoi-0004Bm-Um; Mon, 29 Mar 2021 23:48:57 +0300 Date: Mon, 29 Mar 2021 23:48:47 +0300 To: Sergey Kaplun Message-ID: <20210329204847.GP29703@tarantool.org> References: <20210309175422.25432-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309175422.25432-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294CA3588DDE0233B0D17711AF1EA2D7DB9182A05F538085040BC8012D8D10647A293508B6C0581278BFEE0E95588F2BFB6826085D9FD25F682 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76042E2DB3E33BF2BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E16D8B060A9A23898638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7428A34725AB662D790D67E1DD389CF775B3542AA8A0F2F0A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F790063735872C767BF85DA227C277FBC8AE2E8B8E48D8FAA4D20A9F75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978319D0BA25AB427536E95489C0DEC852D72 X-C1DE0DAB: 0D63561A33F958A55911D4F4B7D6A7AE990E2341AB463E0674D03A91756C313BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34738A88CA0C70A558A89D69C47EFA56EC9C91056D3F5362119E76A47C452B80AF626765A50C0433651D7E09C32AA3244CA35C88D1D7048228DAFB2B9EED64AE253E8609A02908F271927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rRdEmFYDuiPpg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822FF72C4DD47E300C41C981F6AF8728050A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] memprof: report stack resizing as internal event X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the series into tarantool-2.7 and tarantool branches in tarantool/luajit and bumped a new version in 2.7 and master. On 09.03.21, Sergey Kaplun wrote: > Resizing of the Lua stack is not reported as internal allocation. > Moreover, it may lead to crash inside Lua or FF frames. > > Profiler performs reallocation first and after reports corresponding > event. When the stack is resized for local function arguments, the link > to previous frame is invalid in the cause of reallocation. Therefore, > assertion in `debug_framepc()` failes, because of invalid function > reference at previous frame. > > Resolves tarantool/tarantool#5842 > Follows up tarantool/tarantool#5442 > --- > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5842-memprof-core-on-resizestack > Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5842-memprof-core-on-resizestack > Issue: https://github.com/tarantool/tarantool/issues/5842 > > > src/lj_state.c | 6 ++++++ > .../misclib-memprof-lapi.test.lua | 18 ++++++++++++++++++ > 2 files changed, 24 insertions(+) > > -- > 2.28.0 > -- Best regards, IM