From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 25AE86EC60; Mon, 29 Mar 2021 22:11:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25AE86EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617045099; bh=ESilHag8j/hrnSHi8xqRRdoZSUJTc9rDSkJIhVXPGQ4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BoIcsQVuGlTFZ4KtQKZ8Jz11JdKV6I4Mjwkrt1bHTF0ULnSIcpPTQ1BAhG+eeGvxB O72Wyd6ml5LImPTJjp8b+9exUxaSQmtUAHNia1xdYOnid/7jmuipiUPIFWH1YBnSkm orv+esWQ3SzU+IuCrJMN3pzLcYaRtAXtiXIQ6a5E= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E76996EC60 for ; Mon, 29 Mar 2021 22:11:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E76996EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lQxIV-0001Me-Tz; Mon, 29 Mar 2021 22:11:36 +0300 Date: Mon, 29 Mar 2021 22:11:26 +0300 To: Sergey Kaplun Message-ID: <20210329191126.GO29703@tarantool.org> References: <20210326164855.30242-1-skaplun@tarantool.org> <20210326203356.GJ29703@tarantool.org> <20210329111613.GN29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040DAD998AC50D44D0B5505F1B56AE9A99079AE2CA16D46CECDD53955AE3BCEC70E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637770CCD3A0ADFB7EEEA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664F84C2531CF4B857117DA2910C46A78E36AF45DE1A8381668389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D082881546D93491CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFC5EA940A35A165FF2DBA43225CD8A89F890A246B268E114E262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5D7E776A60B519EC3DACED4A5B5A4799E725A4AAAC3D249C8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344B4608D01B1CB59A03D3BE794E576073C8B1FFDE4AD047392B4F34298B99C17E8ED81CB796CC89571D7E09C32AA3244CE36C9E0DA2511DF26C3AD015EC8D94B98580396430872480927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rS1Ul1E06Stwg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638224A8EE25DE5FAE62E09A7A38F02438813A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 29.03.21, Sergey Kaplun wrote: > Igor, > > > Thanks! I like it, exept some typos: > > > > > | ##feature/luajit > > | > > | * Make LuaJIT memory profiler parser output more user-friendly (gh-5811). > > | Now the source line definition where the event occurs is much clearer: > > | only source file name and allocation-related line are presented, > > Typo? s/are presented/is presented/ No, since both *are* presented. > > > | function definition line number is omitted. Moreover, event-related > > Typo: /function definition line number/the function definition line number/. Fixed. > > > | statistics are indicated with units. > > | **Breaking change**: Line info of the line function definition is > > | saved in symbol info table by field `linedefined` now and field `name` > > | is renamed to `source` with the respect to Lua Debug API. > > Typo: s/to Lua Debug/to the Lua Debug/ Fixed. > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM