From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 446F96EC60; Mon, 29 Mar 2021 11:32:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 446F96EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617006734; bh=TTJecoBdqD4S3X8hbRwWcK6HA36ESVP9iogCJOOuDTk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=N3d2/k4A966e+XFoMKsXOSsu/NDD5nHPi09OWmTRKQNL0OqU6+ykI3H4mp/eegQ7D /XleztYb67YinlPBkk//IM8PQ4M4Hi0UmGcwCsurGU/eOsLQEDg09m8gtCvou0UT1S qxoWl1S8YeKJnhrvT049nDkEWcMgs0S9MCHSjO/Q= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1C60B6EC60 for ; Mon, 29 Mar 2021 11:32:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1C60B6EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lQnJj-0004Q0-Rm; Mon, 29 Mar 2021 11:32:12 +0300 Date: Mon, 29 Mar 2021 11:32:02 +0300 To: Sergey Kaplun Message-ID: <20210329083202.GK29703@tarantool.org> References: <20210309175422.25432-1-skaplun@tarantool.org> <20210325201459.GG29703@tarantool.org> <20210326101035.GH29703@tarantool.org> <20210326183856.GI29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F538085040B45E0C4E735FB76F439CBDFF976A5622AD06715E6F58671E09AC33BC8E23B785 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A25B432396ED6D32EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637976142D429C486548638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7428A34725AB662DD1444750C117B3CAC5BCC169A0AFE836A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F790063735872C767BF85DA227C277FBC8AE2E8B47E915A23788DB9575ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A566B5BCECF35BAE65C92C76FAC56C7DE3E01B9A3A1AF5119AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EE19B6E2433CA0932307732F21D6251503B66696070392C6B0C253F694F2FC0ACA9D2F817875DF3D1D7E09C32AA3244C33754BF6CE2F3A9F9173FD3F7B00D7093E8609A02908F271927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rTVATX5w94teQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822B529CCD40917868A3C7DBA9C62287552A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] memprof: report stack resizing as internal event X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 29.03.21, Sergey Kaplun wrote: > Igor, > > > > > > > > > "Feel free to prove the opposite"(c) :) > > > > > > > > The current naming is much better than the previous one, but I still > > > > propose to save the original on and save G(L) into a new variable. > > > > > > Ignoring for now. > > > > Well, if you just need my LGTM, you got it. I'll even push this patch by > > myself. But try to hear my arguments even if they look like "bred deda". > > This is not about LGTM, but about a miscommunication, I hope we will > understand each other's point of view and come to a consensus. I see no changes on the branch, hence we won't. Anyway, you have the necessary amount of LGTMs, so I'll push your patch to the trunk later. > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM