From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CF6F26FC86; Wed, 24 Mar 2021 16:28:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CF6F26FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616592498; bh=AATY3OgIVIE5uKb6OBLnl/sfxXIsi9bB8QCjTRcq2HA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Xi1aT8CQbcTPikib3YHR+JYxq9GF4pGNy4c2zX9STZLshdd8jWo5lsJt888UuKyFO v5jA6UYEnJQF5SiUTem9zAYn9iEs5YnWfRPS6MNZLh5FdgXBSsWsBReDi/zoT+KYij 1XuEQ5LaNpnBknlClpO7ktkV8s3Kw7pTpHDId2DY= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6104E6FC86 for ; Wed, 24 Mar 2021 16:28:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6104E6FC86 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1lP3YW-0004dD-MK; Wed, 24 Mar 2021 16:28:17 +0300 Date: Wed, 24 Mar 2021 13:28:16 +0000 To: Vladislav Shpilevoy Message-ID: <20210324132816.hmkajc5qqqhrq4jv@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F10D3016C09B407F8B1E2E766A3410B623182A05F538085040615D63A2A4EF8993FF70ACEE2BAD226C9FD551F8D80412D896B999F79A3013AA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77603ADE015AF816DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F5B2F26146BDF5648638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5DD360926EF9EC3ABE703C2467C99DE51EA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF696ACC3556E4A6A0BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B666D89E201A891B4676E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B3BBE47FD9DD3FB59A8DF7F3B2552694A2BEBFE083D3B9BA73A03B725D353964BB11811A4A51E3B096D1867E19FE14079BA9C0B312567BB23089D37D7C0E48F6CA18204E546F3947C616AD31D0D18CD5C6D8C47C27EEC5E9FC8A9BA7A39EFB7666BA297DBC24807EA089D37D7C0E48F6C8AA50765F79006379FC65886B7F75608EFF80C71ABB335746BA297DBC24807EA27F269C8F02392CD6143B1329D1CCA5627F269C8F02392CD5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D33FA115173827500355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A53C84A31511D029F0B320EFC163B73B05CC4ED37FECCCD73BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349BD6FB698A487E7E2BC5BB51508D6539328B4E2215691B322F0534EC9BACCD9924BC9ED93ECC52F71D7E09C32AA3244C10155A2544DB171B90D6EC03CA81B34255E75C8D0ED9F6EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNqBGwjEnRoXT6VgchcUwSQ== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD2A049F6D6BE89E46F9FE361D8C3814216B9582B363D799F8FCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 00/16] Cord buffer, static alloc, and Lua GC bug X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 20 мар 01:42, Vladislav Shpilevoy via Tarantool-patches wrote: > The patch attempts to fix most of the easy to face issues with the global > resources not having proper ownership in Lua code and therefore not protected > again being suddenly reused during Lua GC. > > There are many such resources: tarantool_lua_ibuf/IBUF_SHARED, static alloc, > errno, diag/box.error, box_tuple_last, port_c, and others. > > The most easy to screw - ibuf and static alloc. They are fixed in this > patchset. > > The solution is dubious, but there were not found any better alternatives. > > A patch for 1.10 will be sent later in a separate CL. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5632-global-buf-crash-2x > Issue: https://github.com/tarantool/tarantool/issues/5632 I've checked your patchset into 2.6, 2.7 and master. Could you please rebase it onto 1.10? -- Reggards, Kirill Yukhin