From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F2C226FC86; Wed, 24 Mar 2021 03:25:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F2C226FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616545526; bh=8iznYyxqfGEJUjTzxiEtEkOnBBdcsonOVPmJIZ0Du8M=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Xo172hziZjl0H2i6C+DvWirfJoeQGdqMrLgdgvzdJ9jEn08MJg9I+MTef38BFFnxh ZGcSGThopd11JtaONq4QFRO5aEnVM8AdgzOyIVfjmSs7RelGOOQImXSolc3XvXl17v FC4p3gdCCLOoJYJq1RZNr9slUjuJY7Tg45CRSnIE= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 289FE6FC86 for ; Wed, 24 Mar 2021 03:25:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 289FE6FC86 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1lOrKt-0002IV-CX; Wed, 24 Mar 2021 03:25:23 +0300 Date: Wed, 24 Mar 2021 03:25:40 +0300 To: Aleksandr Lyapunov Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210324002540.5kerayajlanmrwk4@tkn_work_nb> References: <1616066671-24689-1-git-send-email-alyapunov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1616066671-24689-1-git-send-email-alyapunov@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F1C82687294EF6886BAE1FA542CE3F1C38182A05F5380850402A6047E9ECBFED703CCE2B1093E24B6D85402BF5FF46ACF289C1ACC421C8DA5B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F16C4DE526EFCC04EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637145E7A1B378D9E388638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C686AF563A045C75E46A7476DF4A98ACDD0A3370C6312E25EA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF633690BD870A8796BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6632B93D3E002A4F776E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B3BBE47FD9DD3FB59A8DF7F3B2552694A57739F23D657EF2B13377AFFFEAFD26923F8577A6DFFEA7C6898EBFCB5D2929593EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B660458B977C3D0C0E089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E702ABEDDA51113D120200306258E7E6ABB4E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E92315FF39D8DB89857825EFA8BF88FCBFD63CE0852D54D1EC5181C00AE116A61B0410A5C07F2F4B726494 X-C1DE0DAB: 0D63561A33F958A597B2C5E8827FEF61EE3F17A697A52C9946F9011639263FF1D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34DFB7A809FB5370874DA28E0C9F112E8AA4FF1E0D5C4D1236B2A7AFA612AD815A201562B62BAB11791D7E09C32AA3244C479667EBBC07DC9123A4C98871EF65B630452B15D76AEC14729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNqBGwjEnRoW2RQMET4iNig== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADE154D23E0C3CEF21375BE70842B811B13B7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] tools: add a script that checks submodules' commits X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Nice idea :) I don't mind any scripts that ease developer / maintainer life. The patch is okay for push (from my point of view), however I would share some thoughts around. Feel free to pass them over if you don't want to pay more time here. I would extend the script for all long-term branches (1.10, 2.*, master) with a submodule specific rules: 1. test-run's commit should be reachable from test-run's master for all long-term branches. 2. I guess it is the same for small, but from what I heard, we possibly will fork a stable branch. So the rule will be like (not sure about X value): - if tarantool's branch is 1.10 / 2.X (X < 8) => small's commit should be reachable from small's tarantool-1.10 branch. - 2.X (X >= 8), master => reachable from small's master. 3. There is master and tarantool-1.10 in msgpuck, similar to above. I would also explicitly skip the checks for pushing to any other branch. So the script may be called before any push and may be integrated into `.git/hooks/pre-push`. This means, a maintainer will place it here once and will not need to run it manually. Maybe it worth to look at the `.git/hooks/pre-push` format from beginning. At least it accepts a branch to push as the second parameter that may be useful. Anyway, the script is useful without those enhancements. WBR, Alexander Turenko. > When the fix is merged to mater it's very simple to make a mistake: Just if'll spin around again: mater -> master.