From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BD60C6FC86; Mon, 22 Mar 2021 10:57:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BD60C6FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616399824; bh=9iNuCZ8l3Tw6tY++waIWRLmucEmwZwet0CUnxvLaurE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cGzGLjZjmzfH0IBtbxtnMmlb6dD1rFVbwcaFmq+Xi64yMIW6JXDVLmBQk8X3z6jeV N2S4HVqkzBfqFEcfL0vs9Gd95MbA/ptomrt3MSsFncFbgQZMuKQCehk0tCU8BYy1no O3IctW9UgTkNt6jn2v+LL9xnSobCcQ1mHT2dK870= Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A56416FC86 for ; Mon, 22 Mar 2021 10:57:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A56416FC86 Received: by mail-wm1-f53.google.com with SMTP id b2-20020a7bc2420000b029010be1081172so8688748wmj.1 for ; Mon, 22 Mar 2021 00:57:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=nk4q5uz0lmCzCkbmgR3j+tdT201Q9VxX4SUa/suGejY=; b=pgVTY32G0lrDuLSOwUyck5CvPJA3CZaiTbcYmSYigd1G72mY8yJdoE1iiepJbXTwlL 6dp4PIZCUzBUFl/nzt2Mr0eKPvbV3LSlEA5CIiuentD+a4OwGXKOlKHKe5AAmaooSD9M 6orkxWyI15CVEI7tIkqgQar1Bx0JFHytrOiY2myW/gu/cn+sbcSE+ETzaAQ191zzJ7Me PgZhk0vV0qaWvLuXxQBzP8l68opVwjFwVh3AE/aumRS5keIqchnjTAVaY1+OE5CvIUEY G7wcXPddx+Gr3K5gf+CVOfg0g3Pk4M8qTwThZZGTT2Eaa7Pa0K77vYh+4lZnWdnNknvH CtpA== X-Gm-Message-State: AOAM532zb3EklEmglXdqTx8spuYiuBzFbCGpjxLwY2/9h1FDC+XCu0Dx VkXKsqhcyJ0KbX4xUYeXNXClsEhY7g== X-Google-Smtp-Source: ABdhPJxWrrQqjmXvU7UDllHNEH52Bf08m08Y6017bDkJmgjqlz34LUmdJJrGBiOizt8a+EjAd6H5Cg== X-Received: by 2002:a7b:c10c:: with SMTP id w12mr15163561wmi.112.1616399821635; Mon, 22 Mar 2021 00:57:01 -0700 (PDT) Received: from sterling.local ([212.57.29.100]) by smtp.gmail.com with ESMTPSA id s9sm16252208wmh.31.2021.03.22.00.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 00:57:00 -0700 (PDT) Received: by sterling.local (Postfix, from userid 1000) id 81F4CE60068; Mon, 22 Mar 2021 10:56:59 +0300 (MSK) Date: Mon, 22 Mar 2021 10:56:59 +0300 To: Vladislav Shpilevoy Message-ID: <20210322075659.GA121167@starling> Mail-Followup-To: Konstantin Osipov , Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com, sergepetrenko@tarantool.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 00/16] Cord buffer, static alloc, and Lua GC bug X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Konstantin Osipov via Tarantool-patches Reply-To: Konstantin Osipov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" * Vladislav Shpilevoy via Tarantool-patches [21/03/22 10:02]: > The patch attempts to fix most of the easy to face issues with the global > resources not having proper ownership in Lua code and therefore not protected > again being suddenly reused during Lua GC. The policy has always been to know what you're doing in gc handlers. Not use shared resources in particular. Not yield. Not try to grab new resources. This is why, specifically, on_shutdown triggers weren't implemented - it's impossible to make them both generic and safe. While this series perhaps won't harm, I doubt they will help much if the user is a rookie. -- Konstantin Osipov, Moscow, Russia