From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 34BDA6EC56; Fri, 19 Mar 2021 14:31:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 34BDA6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616153505; bh=ia4aKKFgbC0VDaE9/3Tgf1t55bb0l+3Hp9/reGcwUPc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Yb9KUUs/U60Y0q11JYcxP+4QP5o/1+55/6iMKslzHFySihe1NzedFZMko28VQOodo WpWlrmJ3QUo2pz2+NgRixf0h3sXYRsD51waE/I6RLo65SsmD/L06wfQuzjz7d7JlVl tAo7QSJVmOx97GB95jVAoF5T9UeO2AkqzHnMHEos= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 512A56EC56 for ; Fri, 19 Mar 2021 14:31:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 512A56EC56 Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1lNDLz-00087D-Eg; Fri, 19 Mar 2021 14:31:43 +0300 Date: Fri, 19 Mar 2021 14:30:52 +0300 To: Igor Munkin Message-ID: <20210319113052.GD28016@root> References: <19e526eec5407d656bbb667870a7a2527ab509a7.1615472551.git.skaplun@tarantool.org> <91E86450-7252-44D8-B6DA-001FD393FB1A@tarantool.org> <20210317151723.GC29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210317151723.GC29703@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96485A7A9FC13189318D1C1B1AED51F3A523B142B0B75A42F182A05F538085040B78FC6938A7C9842D103F99D0C81B3263EA57BC469AA03BE6F9A3AA279DDC427 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72424932217190DC2EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DA5CEC9EE7F170198638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C81A23F326053F827E5E0ADA2078F0D066FB79D0D340C7D3CA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE764603B5C71CE8B8F9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3DF0FDDE43A621D5D117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22495B4C35AC65A386B3089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C054662F8F2CA352F43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A58ADC172CAE475E9F21B9ABA0EEB235AE9F1652EAA295EA05D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EE6683D9E546CC62CB26D032ADAE6C973658C871D856C53709D28E16B5A3316BE23D47CA264115DE1D7E09C32AA3244C04687B994AEDA066491383A57B6CE6BB7C0C08F7987826B9FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyKyJYJ15DtIz1l0IktoQAg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4CD8E45D2DD404F39C88E302DE98947AF4F9D0732C72D4ED6F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: add PUC-Rio Lua 5.1 test suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergos, Igor, Thanks for the review! On 17.03.21, Igor Munkin wrote: > Sergos, > > Thanks for you review! > > On 16.03.21, Sergey Ostanevich wrote: > > Hi! > > > > Thanks for the patch! > > > > > > > > > On 12 Mar 2021, at 08:36, Sergey Kaplun wrote: > > > > > > This patch adds PUC-Rio Lua 5.1 test suite as a part of the LuaJIT > > > test suite. Source code taken verbatim from > > > https://www.lua.org/tests/lua5.1-tests.tar.gz. > > > > > > and is slightly modified to be consistent with the > > > current LuaJIT's LuaC API. > > > > > > > This should be a different commit, isn’t it? > > Yes, it does. Moved into sparate commit, see here [1]. > > > > > > Some tests may fail after this commit. They will be disabled > > > or adapted in the next patches. > > > > The fact patch causes - even temporarily - some fails is no good. The > > only exception is initial commit, that brings original test suite. > > Can you please make a consistent change that will left the tests disabled > > until they adapted and enabled back? > > I believe such juggling with enabling/disabling is quite unprofitable. > We iteratively fix broken tests within the series making CI green as a > result. Even if lib[12].c fails to compile -- it is not a problem, since I've moved compilation rules for this libraries in the separate commit. See patch here [1]. > these libraries are test dependencies, not build ones. Sergey can simply > mention the fact the build of suite-related tests is broken, so one can > find the comment in commit message while e.g. bisecting the bug. > Otherwise, the patches are spoiled with unnecessary changes. > > > > > regards, > > Sergos > > > > > > > > > > > -- > > > 2.28.0 > > > > > > > -- > Best regards, > IM [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2021-March/022788.html -- Best regards, Sergey Kaplun