From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8D8EF6EC56; Fri, 19 Mar 2021 10:40:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8D8EF6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616139631; bh=9UXPNMjPuYMz3sBI1XfPJjaWcaoZl16ttUuqvLRK9ic=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AOC6GA6SJUtbBwrD8A1C23EGbE1fo7sfMNd7yTQd47/9i15hRUO5l6p4oAfOmLTgN 2NMfrzEk1Lp7X+fAb+81M8YcBemi8z+01D6gCeABX2jMViRxvw+CZQrpQ6oig60mDY /GqWZ8FnBptqfAqLUkCHHHUwPw6B8Tz+0Hm60sR8= Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1E3D36EC56 for ; Fri, 19 Mar 2021 10:40:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1E3D36EC56 Received: by mail-lj1-f176.google.com with SMTP id y1so10730549ljm.10 for ; Fri, 19 Mar 2021 00:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Qht7rMyrp+J3Ww2ojFg5oXPsQYLqNEZx/RiiDlW5oy4=; b=Q9UFrcvWvyuAoTwiwG2LqVwvFdY74BMBFKlnEaC04eoBjnA2h/ycZw9r2jq4W8rdlh 7MwP8l1yCGZjsHpe7vphzse/z6N1Z472XHRDVFnWBoKb1MkAqvexCkj+uUms3aqpkYSl CdKKQNIFGRoSmUIe4kGneMQM+dzcDn9vb7Kp5ydXRNY8SvvRmmNiEFErllFTEfT+plWz Q8R4tGve8ZBDYeDzN40heYooCkXGozduukPNv3YxAHdlb99/v4L7iXC8GDU08OITwJxx jkEyAD+AwL5Ssxf4Pj4smbhnnWLHxCrfrS8piJEv4gpTyUY+0RqHLlO2tLDr7anGi1TW hz+w== X-Gm-Message-State: AOAM530c3TwaDOfDTwqgfvZLNslkQqzTabMoO3Qro2x9xJp58pqwiBEa 81Lj6NH7vkHZvem+AXC4VfP9B06jgQ== X-Google-Smtp-Source: ABdhPJyXJ+uxO4+oRNTvWaYMT6+EHdMqJs8u+Fo/iDUXDaIY/eFwr9vv5VVx4UAqxKbNfC5eKqRaHA== X-Received: by 2002:a2e:9dd8:: with SMTP id x24mr62602ljj.173.1616139629649; Fri, 19 Mar 2021 00:40:29 -0700 (PDT) Received: from sterling.local ([46.188.68.12]) by smtp.gmail.com with ESMTPSA id m16sm523286lfo.17.2021.03.19.00.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 00:40:29 -0700 (PDT) Received: by sterling.local (Postfix, from userid 1000) id 89CC5E60068; Fri, 19 Mar 2021 10:40:28 +0300 (MSK) Date: Fri, 19 Mar 2021 10:40:28 +0300 To: Vladislav Shpilevoy Message-ID: <20210319074028.GA75989@starling> Mail-Followup-To: Konstantin Osipov , Vladislav Shpilevoy , Cyrill Gorcunov , tml , Mons Anderson , Serge Petrenko , Kirill Yukhin References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> <20210318051812.GB224985@starling> <20210318075127.GA4019@starling> <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Konstantin Osipov via Tarantool-patches Reply-To: Konstantin Osipov Cc: Mons Anderson , tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" * Vladislav Shpilevoy [21/03/18 23:40]: > >> Good point, thanks! Kostya, lets clarify some moments: > >> > >> 1) We introduce "wal_keep_logs" option which defines > >> a timeout to kick the cleanup fiber. > >> 2) If node is anonymous replica we simply ignore this > >> option. > >> 3) If this option is set then we have a few subcases: > >> a) The `_cluster` space is not empty thus thus once > >> all replicas are subscribed _before_ the timeout > >> expired we trigger the cleanup fiber since it is > >> safe to process; > >> b) If replicas are not connected and timeout is > >> expired we kick the cleanup fiber; > > > > I mean this. > > Then it should have 'replication_' prefix, not 'wal_'. Because > it is ignored if replicas connect before the timeout expires. It defines a property of the wal subsystem. The naming scheme is object-oriented, not subject-oriented. -- Konstantin Osipov, Moscow, Russia https://scylladb.com